Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: better card docs #72

Merged
merged 2 commits into from
Aug 8, 2024
Merged

docs: better card docs #72

merged 2 commits into from
Aug 8, 2024

Conversation

Carl-J-M
Copy link
Contributor

No description provided.

gavmck
gavmck requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@gavmck gavmck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be re-written into normal CSF instead of MDX and add card exmaples of different common card layouts?

gavmck
gavmck reviewed Aug 8, 2024
View reviewed changes
components/canvas/Card/Card.stories.ts Outdated Show resolved Hide resolved
.storybook/styles.css Outdated Show resolved Hide resolved
components/canvas/Card/Card.stories.ts Outdated Show resolved Hide resolved
components/canvas/Card/Card.stories.ts Outdated Show resolved Hide resolved
components/canvas/Card/Card.stories.ts Outdated Show resolved Hide resolved
components/canvas/Card/Card.stories.ts Outdated Show resolved Hide resolved
components/canvas/Card/Card.stories.ts Outdated Show resolved Hide resolved
@Carl-J-M Carl-J-M force-pushed the feature/etch-542-better-card-docs branch from 8535d12 to 6293cb1 Compare August 8, 2024 14:56
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Carl-J-M Carl-J-M requested a review from gavmck August 8, 2024 15:41
@gavmck gavmck merged commit 88f7e05 into main Aug 8, 2024
6 checks passed
@gavmck gavmck deleted the feature/etch-542-better-card-docs branch August 8, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavmck gavmck gavmck approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Carl-J-M @gavmck