docs: input button group select example, fix outline focus issue #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm a little nervous that removing these margin attributes might be a mistake, but I've tested it thoroughly and can't seem to find anything out of place without them, and it fixes the outline distortion issue on the input selects. |
DanWebb
previously requested changes
Aug 21, 2024
JoshTheWanderer
requested changes
Sep 13, 2024
Carl-J-M
force-pushed
the
feature/etch-551-input-button-group-docs-improvements
branch
3 times, most recently
from
682d686 to
661eb9a
Compare
Carl-J-M
force-pushed
the
feature/etch-551-input-button-group-docs-improvements
branch
from
661eb9a to
a0259fa
Compare
|
mergify
bot
requested review from
a team and
JoshTheWanderer
and removed request for
a team
gavmck
deleted the
feature/etch-551-input-button-group-docs-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the focus outline on the button in the input button group was layered behind the input.
Fixed an issue in the input select where a margin applied to the suffix/prefix was distorting the focus outline:
Added a new story for the input button group using a select type input: