Skip to content

Commit

Permalink
Merge pull request #12 from etchteam/feature/etch-842-mop-up
Browse files Browse the repository at this point in the history
Feature/etch 842 mop up
  • Loading branch information
gavmck authored Oct 15, 2024
2 parents f4df641 + dac4fbf commit 220a6d0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions src/components/control/d-tabs.webc
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<style>
d-tabs {
position: relative;
z-index: 1; /* Ensure the tabs are on top of the panels */

ul {
display: flex;
flex-wrap: wrap;
Expand Down
2 changes: 1 addition & 1 deletion src/guide/storybook-example.webc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ date: 2024-10-02

<template webc:type="11ty" 11ty:type="md">

We’ve set up [a Storybook](https://diamond.etch.co/components) to show how Diamond components might look in practice.
We’ve set up <a href="https://diamond.etch.co/components" target="_blank" rel="noopener noreferrer">a Storybook</a> to show how Diamond components might look in practice.

Design system maintainers may want to consider setting up folders like this for each of the four Cs, but it’s an optional step.

Expand Down
6 changes: 3 additions & 3 deletions src/index.webc
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ description: Diamond UI is a methodology for teams who build interfaces.
<h3 class="diamond-text-size-base">Examples</h3>
<ul>
<li>Button &ndash; a clickable component that triggers an action, such as submitting a form</li>
<li>Input &ndash; a hypertext link that takes the user to another page or section of the app</li>
<li>Form &ndash; a form input that allows users to enter information</li>
<li>Link &ndash; a hypertext link that takes the user to another page or section of the app</li>
<li>Input &ndash; a form input that allows users to enter information</li>
</ul>
</diamond-grid-item>
<diamond-grid-item small-mobile="12" small-tablet="6">
Expand Down Expand Up @@ -181,7 +181,7 @@ description: Diamond UI is a methodology for teams who build interfaces.
</p>
<ul>
<li>Bloated with props &ndash; <em>too complicated</em></li>
<li>Updated every time a new design ishanded over &ndash; <em>too specific</em></li>
<li>Updated every time a new design is handed over &ndash; <em>too specific</em></li>
<li>Hard to test &ndash; <em>too many variables</em></li>
<li>Awkward to maintain &ndash; <em>too much time</em></li>
<li>Conflicting or impossible prop combinations &ndash; <em>too specific</em></li>
Expand Down

0 comments on commit 220a6d0

Please sign in to comment.