Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook 8 support #61

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Storybook 8 support #61

merged 10 commits into from
Apr 26, 2024

Conversation

DanWebb
Copy link
Member

@DanWebb DanWebb commented Apr 24, 2024 •
edited
Loading

  • Adds storybook 8 support
  • Cleans up anything we're not using or don't need (including TypeScript)
  • Separates cookie handling into a separate file
  • Moves all dependencies to dev dependencies
  • Documents usage issue with MDX

Fixes #60
Fixes #57

@DanWebb DanWebb self-assigned this Apr 24, 2024
@DanWebb DanWebb marked this pull request as ready for review April 26, 2024 10:11
JoshTheWanderer
JoshTheWanderer previously approved these changes Apr 26, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DanWebb DanWebb merged commit cba4d69 into main Apr 26, 2024
6 checks passed
@DanWebb DanWebb deleted the feature/etch-529-storybook-addon-css-variables-storybook-8-support branch April 26, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshTheWanderer JoshTheWanderer JoshTheWanderer left review comments

Assignees

@DanWebb DanWebb

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS Variables Theme does not work on Storybook 8.0.0 Fix import referencing dist
2 participants
@DanWebb @JoshTheWanderer