Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 8 support #12

Merged

Conversation

DanWebb
Copy link
Member

@DanWebb DanWebb commented May 20, 2024

  • Moves to tsup
  • Removes unnecessary files, dependencies and peer dependencies
  • Adds semantic release
  • General cleanup with linting and ci setup

BREAKING CHANGE: removed all storybook dependencies and react peer dependency, since storybook v8 these are provided by storybook global packages, users on v7 will get an error about the inclusion of @storybook/icons which didn't exist until storybook v8

BREAKING CHANGE: removed all storybook dependencies and
react peer dependency, since storybook v8 these are provided
by storybook global packages
@DanWebb DanWebb self-assigned this May 20, 2024
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DanWebb DanWebb marked this pull request as ready for review May 22, 2024 16:54
@mergify mergify bot merged commit 2ad402e into main May 22, 2024
7 checks passed
@mergify mergify bot deleted the feature/etch-528-storybook-addon-marker-storybook-8-support branch May 22, 2024 16:55
@DanWebb
Copy link
Member Author

DanWebb commented May 28, 2024

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants