Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feedback button not loading #20

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Fix feedback button not loading #20

merged 2 commits into from
Jan 15, 2025

Conversation

DanWebb
Copy link
Member

@DanWebb DanWebb commented Jan 15, 2025 •
edited
Loading

On MDX doc pages and some other unexplained instances, the Storybook decorator doesn't load. Some changes have been made to workaround that:

  • BREAKING CHANGE: Moved from parameters to globals because parameters don't load on MDX-only doc pages.
  • Added a fallback instance of Marker that loads on the manager when the decorator fails, manager screenshots will load outside the iframe so don't have access to styles but it's better than no feedback button displaying

@DanWebb DanWebb self-assigned this Jan 15, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify mergify bot merged commit 359a5c1 into main Jan 15, 2025
8 checks passed
@mergify mergify bot deleted the fix/decorator-fallback branch January 15, 2025 19:05
@DanWebb
Copy link
Member Author

DanWebb commented Jan 15, 2025

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshTheWanderer JoshTheWanderer JoshTheWanderer approved these changes

Assignees

@DanWebb DanWebb

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanWebb @JoshTheWanderer