Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feedback button style #9

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix feedback button style #9

merged 2 commits into from
Feb 9, 2024

Conversation

DanWebb
Copy link
Member

@DanWebb DanWebb commented Feb 8, 2024

Depending on the theme, the button could be hard to spot:

Screenshot 2024-02-08 at 17 28 04

This changes the button to use an IconButton provided by Storybook, same as the other IconButtons in the toolbar, the styles are taken from @etchteam/storybook-addon-css-variables-theme

Screenshot 2024-02-08 at 17 26 52 Screenshot 2024-02-08 at 17 27 02

@DanWebb DanWebb self-assigned this Feb 8, 2024
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mergify mergify bot merged commit e74651f into main Feb 9, 2024
7 checks passed
@mergify mergify bot deleted the fix/feedback-button-color branch February 9, 2024 09:23
@DanWebb
Copy link
Member Author

DanWebb commented May 28, 2024

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants