Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a menu item that will open the config directory in the file explorer of your system :-) #273

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

eteran
Copy link
Owner

@eteran eteran commented Jan 13, 2021

Add a menu item that will open the config directory in the file explorer of your system :-)

See discussion #262

causing Qt to think it was supposed to be an accelerator.

Worse yet, when I added an intended accelerator to that string, it caused
warnings due to there being two accelerators :-P.
@anjohnson
Copy link
Contributor

Any chance you could add a check-box to the Preferences :: Save Defaults dialog for "Don't show this again" at the same time as adding this menu? I'd rather not have to dismiss that dialog every time I save, and the only purpose for it seems to be to tell me where my config files are stored, which this menu will do anyway.

Once that box has been checked the ellipsis should probably get removed from the "Save Defaults ..." menu text too (just to complicate the code slightly, but you did admit you're a perfectionist... 😉 ).

@eteran
Copy link
Owner Author

eteran commented Jan 16, 2021

@anjohnson that's probably a good idea.

Interesting that you caught the subtle meaning of the ... in NEdit menus as meaning "will pop up a dialog", that is indeed what that tends to mean ;-)

@tksoh
Copy link
Contributor

tksoh commented Jan 17, 2021

@eteran in the interest of getting 6.0 out a.s.a.p, perhaps we should stage this PR for 6.1? This will give us more time to work out the best implementation. And you can focus on the milestones :-)

@eteran
Copy link
Owner Author

eteran commented Jan 17, 2021

@tksoh yea, I haven't merged this yet, mostly because it's low priority for 6.0. I don't think we need to "do" anything special as once we tag 6.0, i can just merge this master into this branch to bring it up to speed and basically make it the first feature added to the 6.1 development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants