Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFactor: Separate larft_gemv kernel and add a faster option #1219

Merged
merged 11 commits into from
Nov 25, 2024

Conversation

rasolca
Copy link
Collaborator

@rasolca rasolca commented Nov 22, 2024

Note: currently still use the slow kernel.

Don't want to interfere with @albestro TFactor work.

@rasolca rasolca added Type:New Feature New feature or request Priority:High labels Nov 22, 2024
@rasolca rasolca self-assigned this Nov 22, 2024
@rasolca
Copy link
Collaborator Author

rasolca commented Nov 22, 2024

cscs-ci run

@rasolca
Copy link
Collaborator Author

rasolca commented Nov 22, 2024

cscs-ci run

@rasolca rasolca force-pushed the rasolca/larft_gemv branch 2 times, most recently from 2f4c0db to 3b41e48 Compare November 22, 2024 13:24
@rasolca
Copy link
Collaborator Author

rasolca commented Nov 22, 2024

cscs-ci run

miniapp/kernel/miniapp_larft_gemv.cpp Outdated Show resolved Hide resolved
miniapp/kernel/miniapp_larft_gemv.cpp Outdated Show resolved Hide resolved
miniapp/kernel/miniapp_larft_gemv.cpp Show resolved Hide resolved
test/unit/lapack/gpu/test_larft.cpp Outdated Show resolved Hide resolved
@rasolca
Copy link
Collaborator Author

rasolca commented Nov 22, 2024

cscs-ci run

@rasolca
Copy link
Collaborator Author

rasolca commented Nov 22, 2024

cscs-ci run

Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ROCm pipeline is failing to build, but it's probably only a missing include or similar. This looks good to me otherwise.

@rasolca
Copy link
Collaborator Author

rasolca commented Nov 25, 2024

cscs-ci run

1 similar comment
@rasolca
Copy link
Collaborator Author

rasolca commented Nov 25, 2024

cscs-ci run

@rasolca
Copy link
Collaborator Author

rasolca commented Nov 25, 2024

cscs-ci run

@rasolca
Copy link
Collaborator Author

rasolca commented Nov 25, 2024

cscs-ci run

@rasolca rasolca merged commit 0be8cc9 into master Nov 25, 2024
5 checks passed
@rasolca rasolca deleted the rasolca/larft_gemv branch November 25, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High Type:New Feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants