-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TFactor: Separate larft_gemv kernel and add a faster option #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscs-ci run |
cscs-ci run |
rasolca
force-pushed
the
rasolca/larft_gemv
branch
2 times, most recently
from
November 22, 2024 13:24
2f4c0db
to
3b41e48
Compare
rasolca
force-pushed
the
rasolca/larft_gemv
branch
from
November 22, 2024 13:37
3b41e48
to
4822555
Compare
cscs-ci run |
msimberg
requested changes
Nov 22, 2024
cscs-ci run |
cscs-ci run |
msimberg
reviewed
Nov 22, 2024
msimberg
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like ROCm pipeline is failing to build, but it's probably only a missing include or similar. This looks good to me otherwise.
cscs-ci run |
1 similar comment
cscs-ci run |
cscs-ci run |
rasolca
force-pushed
the
rasolca/larft_gemv
branch
from
November 25, 2024 16:36
37655e0
to
1fb1f7e
Compare
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: currently still use the slow kernel.
Don't want to interfere with @albestro TFactor work.