-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation etc. to use uenv start --view
instead of uenv view
#186
base: main
Are you sure you want to change the base?
Conversation
docs/uenv-linaro-forge.md
Outdated
The `/user-tools/activate` script will make the forge executables available in your environment, and **must be run before** | ||
any other uenv view command otherwise the environment variables set from the other uenv will be overwritten. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgphpc could you clarify what the requirements are here? Is the /user-tools/activate
script not going to work correctly with the view loaded at start
? Is it a requirement to source the activate
script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time of doc writing, this was the only way but now, loading 2 views is working fine:
uenv start prgenv-gnu/24.11:v1,linaro-forge/24.0.2:v1 -v forge,prgenv-gnu:default
uenv start prgenv-gnu/24.11:v1,e0e79f5c3e6a8ee0 -v forge,prgenv-gnu:default
which nvcc
/user-environment/env/default/bin/nvcc
which ddt
/user-tools/env/forge/bin/ddt
so it's fine to remove that part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jgphpc! I've updated this to load both uenvs and views in one command. Please have a look to see if it's sane to you.
# TODO: Update this and other reframe activations? | ||
activation: uenv view develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there someone who knows if these activations still work with the new uenv? Does reframe need changes to support loading a view at uenv start
-time?
@ekouts you might know best what's supported/required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reframe has support for loading views at start time.
There is a view
parameter that can be configured in the extra/reframe.yaml
file that specifies which view(s) to load.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the cp2k recipe for example:
https://github.com/eth-cscs/alps-uenv/blob/main/recipes/cp2k/2024.3/gh200/extra/reframe.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Updated (all the prgenv-gnu recipes). If I understand correctly, these recipes would need to be rebuilt and deployed with a new version to be able to use the updated reframe.yaml files, yes? (Though all the recipes older than 24.11 probably don't benefit from a rebuild.)
From my perspective this can wait for the next version bump of the prgenv-gnu uenvs, though it wouldn't hurt to have a prgenv-gnu which works with the new uenv. Feels a bit strange to bump it to v2 with a non-user-facing change, but maybe it doesn't matter. Preferences?
e77ccdc
to
0e44fff
Compare
0e44fff
to
abc48cc
Compare
No description provided.