Using grep to limit default NM_SRC_BUILD_TARGET #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regex: "^[0-9]+[.][0-9]+[.][0-9]+$" . This avoids building from tags like "1.20.0-rc" or "1.17.0-unstable"
|
My assumption was that someone who source-builds will seek out a specific tag, and the default is just there as a fallback - and yes, this seems fine to change. |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 eth-docker Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using grep to limit default NM_SRC_BUILD_TARGET to tags that match
regex: "^[0-9]+[.][0-9]+[.][0-9]+$" . This avoids building from tags like "1.20.0-rc" or "1.17.0-unstable"
This is a fix for issue #1433