Updates to el-architecture #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
El architecture file update : Added the modifications that were already done by Mario during the review of my last PR
Prettier ends up breaking the table by adding an additional column in the header
More updates to overview, walked back the idea of doing a tabular style comparison on clients under specific components, this will prove to be a collaboration hell. Thus, in the new proposed doc scheme each client should have its own heading under a component.
|
Thanks for following up on this! I will leave detailed review later as the content progresses. Reading it now, the structure and wording is great, just keep an eye on those extra spaces, capital letters, etc |
|
|
||
| Note: client specific overviews will go here | ||
|
|
||
| ### Reth |
There was a problem hiding this comment.
The part dedicated to reth is pretty client specific and thorough. It could become its own page similar to #191 with extra info for contributors and make this page leaner.
There was a problem hiding this comment.
Sounds great, will do that at some point today
|
|
||
| 2. **Blob Pools**: Unlike legacy pools, blob pools maintain a priority heap for transaction eviction but incorporate distinct mechanisms for operation. Notably, the implementation of blob pools is well-documented, with an extensive comments section available for review [here](https://github.com/ethereum/go-ethereum/blob/064f37d6f67a012eea0bf8d410346fb1684004b4/core/txpool/blobpool/blobpool.go#L132). A key feature of blob pools is the use of logarithmic functions in their eviction queues. | ||
|
|
||
| ### EVM |
There was a problem hiding this comment.
Following pages - EVM, devp2p, mpt, rlp, etc have their own dedicate page. You can just provide a context and refer people to other pages to keep it relatively simple :)
|
Closing in favor of #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enthusiastically merged the previous PR before reading through all of the comments. This PR is used to monitor any revisions to the recommendations that were made during the previous PR's review.
PR Checklist
Architecture File
Specs File
(may do a separate PR for this since this file is long and any work on it is time consuming)