-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cryptography/bls #218
Cryptography/bls #218
Conversation
…ol-studies into cryptography/BLS
BLS page in Cryptography section
Following typos were found in the pull request:
ℹ️ Here's how to fix them:
|
A topic addressing Aggregation and verification of BLS signatures in Ethereum CL is remaining, but unsure if I should add it here or in CL page. |
BLS aggregation should be in CL page - with references to the math page. Just a personal take, tho |
I would recommend you include everything related to BLS signatures in one page and then refer the document wherever necessary. Ensures completness within the page, whch IMO is convenient for perusal |
Nice work @shyam-patel-kira. I will review this. @thogiti It would be awesome if you review it too. I would suggest keeping aggregation and verification under BLS and maybe have a short 1 para primer in CL and point to this BLS wiki for in-depth coverage. You could merge this and that later too. |
@raxhvl I will review it tonight. Thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for creating the page! It's really great, I left some minor edits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome article, @shyam-patel-kira. Thank you for writing this for our wiki.
Co-authored-by: Mário Havel <[email protected]>
Co-authored-by: Mário Havel <[email protected]>
Co-authored-by: Mário Havel <[email protected]>
…llows/protocol-studies into cryptography/BLS
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates to cl clients as well! The page seems to be almost done, please ping me when you consider it ready to be merged.
I think it's ready to be merged, I'll include a section on the use of BLS aggregation in beacon-chain when I come across it while writing on CL, in a separate PR in case no one as done it by then Thanks for reviewing: @taxmeifyoucan, @thogiti, @gorondan, @raxhvl |
Co-authored-by: rahul <[email protected]>
Co-authored-by: rahul <[email protected]>
Co-authored-by: rahul <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Following typos were found in the pull request:
ℹ️ Here's how to fix them:
|
resolves #137