Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptography/bls #218

Merged
merged 35 commits into from
Apr 29, 2024
Merged

Cryptography/bls #218

merged 35 commits into from
Apr 29, 2024

Conversation

shyam-patel-kira
Copy link
Member

resolves #137

  • Added in-depth BLS explanation using math
  • Added BLS in context of Ethereum

Copy link

Hi @shyam-patel-kira,

Following typos were found in the pull request:

  • 📄 ./docs/wiki/Cryptography/bls.md:
    1. Shacham
    2. bilinear
    3. rightarrow
    4. computable
    5. bilinear
    6. bilinearity
    7. Schnorr
    8. bilinear
    9. Schnorr
    10. sigatures
    11. verifications
    12. ldots
    13. aggregative
    14. validator's
    15. atleast
    16. IRTF
    17. keystore
    18. validator’s
    19. rightarrow
    20. validator's
    21. IETF
    22. Hasing
    23. keystore

ℹ️ Here's how to fix them:

  • Fix typos: Open the relevant files and fix any identified typos.
  • Update wordlist: If a flagged word is actually a project-specific term add it to wordlist.txt in the project root.
    Each word should be listed on a separate line. Learn more.
  • 🚧 Remember:
    • When adding new words it MUST NOT have any spaces or special characters within or around it.
    • wordlist is NOT case sensitive.
    • Use backticks to quote code variables so as to not bloat the wordlist.

@shyam-patel-kira shyam-patel-kira self-assigned this Apr 24, 2024
@shyam-patel-kira shyam-patel-kira added the documentation Improvements or additions to documentation label Apr 24, 2024
@shyam-patel-kira
Copy link
Member Author

A topic addressing Aggregation and verification of BLS signatures in Ethereum CL is remaining, but unsure if I should add it here or in CL page.
cc: @raxhvl @taxmeifyoucan

@gorondan
Copy link
Contributor

gorondan commented Apr 25, 2024

unsure if I should add it here or in CL page.

BLS aggregation should be in CL page - with references to the math page. Just a personal take, tho

@chirag-parmar
Copy link
Contributor

A topic addressing Aggregation and verification of BLS signatures in Ethereum CL is remaining, but unsure if I should add it here or in CL page. cc: @raxhvl @taxmeifyoucan

I would recommend you include everything related to BLS signatures in one page and then refer the document wherever necessary. Ensures completness within the page, whch IMO is convenient for perusal

@raxhvl raxhvl requested a review from thogiti April 25, 2024 07:32
@raxhvl
Copy link
Member

raxhvl commented Apr 25, 2024

Nice work @shyam-patel-kira. I will review this. @thogiti It would be awesome if you review it too.

I would suggest keeping aggregation and verification under BLS and maybe have a short 1 para primer in CL and point to this BLS wiki for in-depth coverage.

You could merge this and that later too.

@thogiti
Copy link
Contributor

thogiti commented Apr 25, 2024

@raxhvl I will review it tonight. Thx.

Copy link
Contributor

@taxmeifyoucan taxmeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for creating the page! It's really great, I left some minor edits

docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thogiti thogiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome article, @shyam-patel-kira. Thank you for writing this for our wiki.

docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved

This comment was marked as resolved.

Copy link
Contributor

@taxmeifyoucan taxmeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates to cl clients as well! The page seems to be almost done, please ping me when you consider it ready to be merged.

docs/wiki/CL/cl-clients.md Outdated Show resolved Hide resolved
@shyam-patel-kira
Copy link
Member Author

shyam-patel-kira commented Apr 26, 2024

Thanks for the updates to cl clients as well! The page seems to be almost done, please ping me when you consider it ready to be merged.

I think it's ready to be merged, I'll include a section on the use of BLS aggregation in beacon-chain when I come across it while writing on CL, in a separate PR in case no one as done it by then

Thanks for reviewing: @taxmeifyoucan, @thogiti, @gorondan, @raxhvl

docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Outdated Show resolved Hide resolved
docs/wiki/Cryptography/bls.md Show resolved Hide resolved

This comment was marked as resolved.

@taxmeifyoucan taxmeifyoucan merged commit 2fe410f into main Apr 29, 2024
@taxmeifyoucan taxmeifyoucan deleted the cryptography/BLS branch April 29, 2024 15:05
Copy link

Hi @shyam-patel-kira,

Following typos were found in the pull request:

  • 📄 ./docs/eps/intro.md:
    1. Developsment

ℹ️ Here's how to fix them:

  • Fix typos: Open the relevant files and fix any identified typos.
  • Update wordlist: If a flagged word is actually a project-specific term add it to wordlist.txt in the project root.
    Each word should be listed on a separate line. Learn more.
  • 🚧 Remember:
    • When adding new words it MUST NOT have any spaces or special characters within or around it.
    • wordlist is NOT case sensitive.
    • Use backticks to quote code variables so as to not bloat the wordlist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ BLS digital signature
6 participants