Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

El architecture update - reth #242

Merged
merged 39 commits into from
May 1, 2024
Merged

El architecture update - reth #242

merged 39 commits into from
May 1, 2024

Conversation

SiddharthV1
Copy link
Contributor

Add section on reth's storage from week 7

thogiti and others added 30 commits April 28, 2024 16:46
@thogiti
RLP wiki page - first commit
8255738
@thogiti
data serialization section is added
441c9c1
@thogiti
need for RLP in Ethereum section is addecd
accb498
@SiddharthV1
Fix overview image
97cc262
@thogiti
RL encoding/decoding sections are added
56abb2e
@thogiti
RLP tools and resources sections are added.
8bc7f0b
@thogiti
fixed the sidebar conflicts
405d9d1
@thogiti
fixed the sidebar conflicts
9a1c992
@thogiti
fixed the sidebar conflicts
640266b
@thogiti
fixed the sidebar conflicts
0e1b1a5
@thogiti
fixed the sidebar conflicts
71c7366
@thogiti
fixed the sidebar conflicts
cdf2dd4
@thogiti
Merge remote-tracking branch 'upstream/el-architecture' into el-archi…
54a8009 
…tecture
@thogiti
RLP links to sidebar is added
84325ab
@thogiti
Merge pull request #229 from thogiti/el-architecture
14ddf02 
RLP wiki page
@thogiti
typos for wordlist is fixed
e3016a5
@thogiti
Merge pull request #233 from thogiti/el-architecture
e6be715 
typos for wordlist is fixed
@thogiti
typos for wordlist is fixed
ee87d71
@thogiti
Merge pull request #234 from thogiti/el-architecture
08e371b 
typos for wordlist is fixed
@thogiti @taxmeifyoucan
Update docs/wiki/EL/RLP.md
f2af327 
Co-authored-by: Mário Havel <[email protected]>
@thogiti @taxmeifyoucan
Update docs/wiki/EL/RLP.md
14e6373 
Co-authored-by: Mário Havel <[email protected]>
@thogiti
Updated after the review
bfd0299
@thogiti
Merge branch 'el-architecture' into el-architecture
9b89818
@thogiti
Merge pull request #235 from thogiti/el-architecture
d6387a4 
Updated after the review
@thogiti
resolve conflict
6d8749e
@SiddharthV1
Link RLP page in architecture doc
41c0970
@SiddharthV1
Cross-links & move RLP heading under DataStructure
5fc0944
@taxmeifyoucan
additions to the intro
bf37786
@thogiti
resolve conflicts
45233cd
@thogiti
Merge pull request #238 from thogiti/el-architecture
dd63838 
El architecture
@SiddharthV1 SiddharthV1 self-assigned this May 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

Hi @SiddharthV1,

Following typos were found in the pull request:

  • 📄 ./docs/wiki/EL/clients/reth.md:
    1. ShardedKey
    2. StoragesHistory
    3. StorageShardedKey
    4. merkelization
    5. HashedStorages
    6. usefull
    7. merklization
    8. StoragesTrie
    9. mekle

ℹ️ Here's how to fix them:

  • Fix typos: Open the relevant files and fix any identified typos.
  • Update wordlist: If a flagged word is actually a project-specific term add it to wordlist.txt in the project root.
    Each word should be listed on a separate line. Learn more.
  • 🚧 Remember:
    • When adding new words it MUST NOT have any spaces or special characters within or around it.
    • wordlist is NOT case sensitive.
    • Use backticks to quote code variables so as to not bloat the wordlist.

@SiddharthV1 SiddharthV1 changed the title El architecture update El architecture update - reth May 1, 2024
taxmeifyoucan
taxmeifyoucan approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@taxmeifyoucan taxmeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for adding the table. I shared a similar one for geth which can be elaborated on with descriptions like here

@taxmeifyoucan taxmeifyoucan merged commit 3369c66 into main May 1, 2024
2 checks passed
@taxmeifyoucan taxmeifyoucan deleted the el-architecture branch May 1, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taxmeifyoucan taxmeifyoucan taxmeifyoucan approved these changes

Assignees

@SiddharthV1 SiddharthV1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiddharthV1 @taxmeifyoucan @thogiti