Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added prerequisites requirement for pages subject to change #250

Merged
merged 3 commits into from
May 3, 2024

Conversation

gorondan
Copy link
Contributor

@gorondan gorondan commented May 2, 2024

Wiki PR Checklist

Thank you for contributing to the Protocol Wiki! Before you open a PR, make sure to read information for contributors and take a look at following checklist:

  • Describe your changes, substitute this text with the information
    added prerequisites requirement for pages subject to change, in contributing.md
  • If you are touching an existing piece of content, ask the original creator for review

@gorondan
Copy link
Contributor Author

gorondan commented May 2, 2024

according to #249
fixes the topic on artifacts, as discussed in #225

Copy link
Member

@raxhvl raxhvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response. I have added headings to both sections so that it can be referenced easily.

docs/contributing.md Outdated Show resolved Hide resolved
> [!WARNING]
> This document covers an active area of research, may be outdated at time of reading and subject to future updates, as the design space around (*active research topic, e.g. Inclusion Lists*) evolves.

* Roadmap tracker artifact using the following format:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Roadmap tracker artifact using the following format:
#### Rodmap format
Roadmap tracker artifact using the following format:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing about roadmap tracker: if we go for the proposed changes, it's not clear imo if the tracker should be added to all pages or just to research pages(acc. to this discussion). That's why in the initial commit, both artifacts were presented under research pages

@taxmeifyoucan taxmeifyoucan merged commit 30d57dc into eth-protocol-fellows:main May 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants