Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Kurtosis to Testing #279

Merged
merged 9 commits into from
May 30, 2024
Merged

Adding Kurtosis to Testing #279

merged 9 commits into from
May 30, 2024

Conversation

faytey
Copy link
Contributor

@faytey faytey commented May 25, 2024

  • Adding Kurtosis to the Testing Module in the wiki

@faytey faytey mentioned this pull request May 25, 2024
Open
@arredr2 arredr2 self-requested a review May 28, 2024 21:16
@arredr2
Copy link
Member

arredr2 commented May 28, 2024

Cheers @faytey! I think this looks good.

@arredr2 arredr2 requested a review from raxhvl May 28, 2024 21:17
@raxhvl
Copy link
Member

raxhvl commented May 29, 2024

Hey @faytey! Thanks for adding this. Feedback:

  • Could you highlight the importance of Kurtosis in Ethereum development and testing? There is a kurtosis package for Ethereum. See this for inspiration.

@raxhvl raxhvl requested a review from taxmeifyoucan May 29, 2024 06:16
@faytey
Copy link
Contributor Author

faytey commented May 29, 2024

Hey @faytey! Thanks for adding this. Feedback:

  • Could you highlight the importance of Kurtosis in Ethereum development and testing? There is a kurtosis package for Ethereum. See this for inspiration.

Hi Sir, I've made some edits

@raxhvl
Copy link
Member

raxhvl commented May 29, 2024

Excellent! thanks

@raxhvl raxhvl merged commit 2f87fa7 into eth-protocol-fellows:main May 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxhvl raxhvl raxhvl approved these changes

@arredr2 arredr2 arredr2 approved these changes

@taxmeifyoucan taxmeifyoucan Awaiting requested review from taxmeifyoucan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faytey @arredr2 @raxhvl