Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing an issue with missing propTypes #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing an issue with missing propTypes #36

wants to merge 1 commit into from

Commits on Jul 27, 2020

  1. Fixing an issue with missing propTypes 

    Don't really understand the issue, but this fixes ethanselzer#35 by:

1. providing an empty object to Object.keys as a default
2. only emitting the event when there's actually something to send along with it

This fixes an issue I was having with another component using this one (ethanselzer/react-image-magnify)
    @Coriou
    Coriou committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    e2fd02c View commit details
    Browse the repository at this point in the history