Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29 Attempts to clarify position field for arguments #33

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

jtoman
Copy link
Contributor

@jtoman jtoman commented Jun 27, 2023

Clarifies that the position given in arguments information gives the index into the (well-ordered) formal parameter list. Tagging @cameel because I can't request a review?

Closes #29

@jtoman jtoman changed the title Attempts to clarify position field for arguments #29 Attempts to clarify position field for arguments Jun 27, 2023
@cameel
Copy link
Contributor

cameel commented Jun 28, 2023

Test comment to see if that allows you to add me as a reviewer.

@cameel cameel self-requested a review June 28, 2023 17:03
@cameel
Copy link
Contributor

cameel commented Jun 28, 2023

@gnidan invited me to the org so now I can add myself :)

Copy link
Contributor

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Found only some minor text issues.

docs/source/format.md Outdated Show resolved Hide resolved
docs/source/format.md Outdated Show resolved Hide resolved
@gnidan gnidan merged commit 96ad10e into main Sep 1, 2023
1 check passed
@gnidan gnidan deleted the jtoman/clarify-positional-named branch September 1, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarification on argument's position
3 participants