Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define function types #63

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Define function types #63

merged 1 commit into from
Jan 7, 2024

Conversation

gnidan
Copy link
Member

@gnidan gnidan commented Jan 7, 2024

  • Use contains object mapping style for parameters types and returns types. Force parameters to be a type wrapper around a tuple type (and allow returns to be any other kind of type)

  • Define one-of required fields internal: true xor external: true.

  • Override external types contains field to also allow a contract field (for the contract in which an external function type is defined)

- Use `contains` object mapping style for `parameters` types and
  `returns` types. Force `parameters` to be a type wrapper around a
  tuple type (and allow `returns` to be a tuple type)

- Define one-of required fields `internal: true` xor `external: true`.

- Override external types `contains` field to also allow a `contract`
  field (for the contract in which an external function type is defined)
@gnidan gnidan merged commit 4bd5303 into main Jan 7, 2024
4 checks passed
@gnidan gnidan deleted the function-types branch January 7, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant