Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headings alignment #45

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Fix headings alignment #45

merged 2 commits into from
Oct 8, 2023

Conversation

webzwo0i
Copy link
Member

adds test coverage for aligning headings.

Ensures ep_headings2 is called before ep_align. In case ep_headings2 isn't installed, the additional post declaration in ep.json seems to be ignored (there is no dependency on ep_headings2).

@rhansen
Copy link
Member

rhansen commented Mar 2, 2022

Sorry, I didn't see this until just now.

What problem is this solving?

@webzwo0i
Copy link
Member Author

webzwo0i commented Mar 6, 2022

Making it possible to align headings. Without this, you can't e.g. center a heading

@webzwo0i
Copy link
Member Author

webzwo0i commented Mar 6, 2022

iirc it was not installation-dependent, probably because there is some lexical sorting to determine the order plugins are called so that align precedes headings2 without the post declaration

@SamTV12345 SamTV12345 merged commit a571e07 into ether:main Oct 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants