-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApeChain mainnet #6034
Add ApeChain mainnet #6034
Conversation
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, ship it
I don't think I have perms to add him as a reviewer on GH. @ligi can you please review? |
@joescherping sorry I'm not a maintainer so can't add @ligi as reviewer but hoping they see this and can help review and merge soon. |
1 similar comment
it's already appearing on chainlist but with different metadata: https://chainlist.org/?search=33139 |
rebase the PR or allow me to rebase |
7cdd493
to
171b216
Compare
Apologies for that @ligi, just rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I checked it and could merge - but stupid meme chains are not merged for free - so pay 420 DAI to lists.eth and sent the tx id here
I guess this is a joke😅 @ligi |
@ligi We will sponsor this merge. Tx IDs are below. Please help merge in the next 24 hours. thanks |
PR merged - please consider contributing some funds to lists.eth |
No description provided.