Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApeChain mainnet #6034

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

MYKatz
Copy link
Contributor

@MYKatz MYKatz commented Oct 19, 2024

No description provided.

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

@queenmoon-bot
Copy link

Copy link

@dmrazzy dmrazzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link

@kaisung kaisung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, ship it

@kaisung
Copy link

kaisung commented Oct 21, 2024

@MYKatz might need to assign @ligi for review

@MYKatz
Copy link
Contributor Author

MYKatz commented Oct 21, 2024

I don't think I have perms to add him as a reviewer on GH. @ligi can you please review?

@MYKatz MYKatz marked this pull request as draft October 21, 2024 23:31
@MYKatz MYKatz marked this pull request as ready for review October 21, 2024 23:31
@joescherping
Copy link

Hello! I am also interested in getting ApeChain on the chain list - I created a PR for it but then deleted it when I realized it was a duplicate of this one. @kaisung can you add @ligi as a reviewer? Thanks all! 🚀

@kaisung
Copy link

kaisung commented Oct 23, 2024

Hello! I am also interested in getting ApeChain on the chain list - I created a PR for it but then deleted it when I realized it was a duplicate of this one. @kaisung can you add @ligi as a reviewer? Thanks all! 🚀

@joescherping sorry I'm not a maintainer so can't add @ligi as reviewer but hoping they see this and can help review and merge soon.

@Ramyromel
Copy link

@ligi

1 similar comment
@joshuanwankwo
Copy link

@ligi

@joescherping
Copy link

it's already appearing on chainlist but with different metadata: https://chainlist.org/?search=33139

@ligi
Copy link
Member

ligi commented Oct 24, 2024

rebase the PR or allow me to rebase

@MYKatz
Copy link
Contributor Author

MYKatz commented Oct 24, 2024

Apologies for that @ligi, just rebased.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I checked it and could merge - but stupid meme chains are not merged for free - so pay 420 DAI to lists.eth and sent the tx id here

@joshuanwankwo
Copy link

joshuanwankwo commented Oct 25, 2024

I guess this is a joke😅 @ligi

@kaisung
Copy link

kaisung commented Oct 25, 2024

@ligi We will sponsor this merge. Tx IDs are below. Please help merge in the next 24 hours. thanks
https://etherscan.io/tx/0x59042d0c6833ac6099627b19a2ef749ce3ebfbea4d0fb15a54bc60f5eeb6cdec
https://etherscan.io/tx/0x378e80bf65542888c7965c4ff93e5911d789e7e70dc8bf41ea227a762a2c5e9c

@ligi ligi merged commit b02f883 into ethereum-lists:master Oct 25, 2024
5 checks passed
Copy link

PR merged - please consider contributing some funds to lists.eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants