Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Old Version of Cronos zkEVM chain #6052

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Conversation

aw126
Copy link
Contributor

@aw126 aw126 commented Oct 23, 2024

@ligi, there's a new iteration of Cronos zkEVM testnet and the official chainId has changed from 282 to 240.

This PR is deprecating the older version of testnet. I will create another PR to add a new chainId.

@ligi, there's a new iteration of Cronos zkEVM testnet and the official chainId has changed from `282` to `240`. 

This PR is deprecating the older version of testnet. I will create another PR to add a new chainId.
Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

aw126 added a commit to aw126/chains that referenced this pull request Oct 23, 2024
We deprecated our previous version of Cronos zkEVM testnet and made the deprecate request here: ethereum-lists#6052 

This PR adds a new chainID and networkID for new version of testnet.
@ElvisKrop
Copy link
Contributor

Hey @aw126 👋
Please update the rpc endpoints in this PR to the deprecated. Build fails because of this issue:

Exception in thread "main" java.lang.IllegalStateException: RPC chainId (240) does not match chainId from json (282)

In addition, please update the chain and shortname with the prefix "deprecated". This will enable the automated checks to be successful at #6053

@aw126
Copy link
Contributor Author

aw126 commented Oct 25, 2024

update the chain and shortname with the prefix "deprecated"

@ElvisKrop Thanks for the suggestions! The automated checks have passed 👍

@ligi ligi merged commit 13117d2 into ethereum-lists:master Oct 25, 2024
5 checks passed
Copy link

PR merged - please consider contributing some funds to lists.eth

ligi pushed a commit that referenced this pull request Oct 28, 2024
We deprecated our previous version of Cronos zkEVM testnet and made the deprecate request here: #6052 

This PR adds a new chainID and networkID for new version of testnet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants