Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Version of Cronos zkEVM Testnet #6053

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

aw126
Copy link
Contributor

@aw126 aw126 commented Oct 23, 2024

A new Cronos zkEVM testnet has been launched, and we made the deprecate request for the old testnet here: #6052

This PR adds a new ChainID and NetworkID for new version of Cronos zkEVM testnet.

We deprecated our previous version of Cronos zkEVM testnet and made the deprecate request here: ethereum-lists#6052 

This PR adds a new chainID and networkID for new version of testnet.
Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link

@Dubersnack Dubersnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds support for the Cronos zkEVM Testnet to the eip155-240.json file. The information provided appears accurate and complete, including the RPC URL, faucet URL, native currency details, explorer URL, and other relevant chain specifications.
Adding support for this testnet will enable users to easily interact with the Cronos zkEVM Testnet and explore its features. This is a valuable addition to the project and will benefit developers and users interested in experimenting with this new technology.

Suggestions:

  • Consider adding a link to the official Cronos zkEVM Testnet documentation in the infoURL field.

  • It might be helpful to include a brief description of the Cronos zkEVM Testnet and its purpose in a comment within the JSON file.

Overall, this is a well-prepared pull request that adds valuable functionality to the project.

@ElvisKrop
Copy link
Contributor

Hey @aw126 👋
Sync your branch with the base branch (ethereum-lists:master). You have updated the Deprecated Testnet data and your current PR should not have conflicts anymore.
Have a pleasant week ahead!

@aw126
Copy link
Contributor Author

aw126 commented Oct 28, 2024

@ElvisKrop 👋
Awesome. It's now synced with the base branch, all checked passed as expected, and pending for merge.
Cheers!

@ligi ligi merged commit 0f22220 into ethereum-lists:master Oct 28, 2024
5 checks passed
Copy link

PR merged - please consider contributing some funds to lists.eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants