-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Toki Network and Toki Testnet #1426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short name must be unique - but found TOKI
more than once
also rebase to master please
and the icon should have width
and height
fields
Fixed. I modified the README slightly, because it is inconsistent. Please advise if the copy should be adjusted. |
/rebase |
…eight, and update README.md
Co-authored-by: ligi <[email protected]>
Rebased |
@ligi Remove network? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea - and copy the other jsons schema / style introduced in #1509 - @ashutoshpw can you maybe add to the readme a section about this?
Will be adding this soon. |
This is auto-formatted if you have prettier extension installed in VS Code. If you don't have extension installed, you can format the files by running this command in project root directory. (You should have NodeJS installed in your system for this to run)
|
@ashutoshpw I formatted the files after I saw the error in the CI. :) |
* Add Toki Network and Toki Testnet * Change Toki Testnet short name, update Toki icon to include width & height, and update README.md * Reorder Toki icon fields for consistency * Update _data/icons/toki.json Co-authored-by: ligi <[email protected]> * Update SVG to have width/height defined * Remove network property from Toki Networks * Run prettier on Toki Networks Co-authored-by: ligi <[email protected]>
* Add Toki Network and Toki Testnet * Change Toki Testnet short name, update Toki icon to include width & height, and update README.md * Reorder Toki icon fields for consistency * Update _data/icons/toki.json Co-authored-by: ligi <[email protected]> * Update SVG to have width/height defined * Remove network property from Toki Networks * Run prettier on Toki Networks Co-authored-by: ligi <[email protected]>
No description provided.