Add new rpc to existing ones #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ligi if you can approve this one, we added a new RPC to our chain |
ligi
requested changes
Sep 11, 2024
|
I did it on purpose to make the new one first and more desirable. On my last update, that wasn't the requirement. |
|
what last update are you referencing? |
|
My last PR for updating this file. Can you pls approve, the one I added is the most desirable now to be added in the wallet? |
|
If it's a must, I'll put it at the end, I just want this change to be reflected as soon as possible. |
|
provide a link to the last PR |
|
all ok or I need to resubmit @ligi ? |
|
ping @ligi |
1 similar comment
|
ping @ligi |
ligi
approved these changes
Sep 22, 2024
|
PR merged - please consider contributing some funds to lists.eth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.