Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Ethernity and Arena-z icons #6007

Merged
merged 10 commits into from
Oct 15, 2024

Conversation

anirudhmakhana
Copy link
Contributor

No description provided.

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

@anirudhmakhana
Copy link
Contributor Author

@ligi

i have now updated the icons to show directly

could you help re-trigger the workflow please, thanks!

@anirudhmakhana anirudhmakhana marked this pull request as draft October 15, 2024 14:35
@anirudhmakhana anirudhmakhana marked this pull request as ready for review October 15, 2024 14:35
@anirudhmakhana
Copy link
Contributor Author

@ligi why is this still failing?

when we can clearly use ipfs get and get the image directly 🤔

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I could not resolve your CID with ipfs get in a reasonable time or cloudflare could not resolve the image in a reasonable time for the CI - maybe you have the icon only locally in your ipfs node that is not properly connected or there is some other IPFS problem - and before having a back and forth here I require you to put it in iconDownload. Before this back and forth did cost me a lot of time that I do not have.

@ligi ligi merged commit 6053502 into ethereum-lists:master Oct 15, 2024
5 checks passed
Copy link

PR merged - please consider contributing some funds to lists.eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants