Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accumulate Kermit #6066

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Accumulate Kermit #6066

merged 2 commits into from
Oct 25, 2024

Conversation

firelizzard18
Copy link
Contributor

@github-actions GitHub Actions
Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

ligi
ligi requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explorer does not seem to be EIP3091 compatible when it comes to addresses

@firelizzard18
Copy link
Contributor Author

@ligi I added a route for addresses: https://kermit.explorer.accumulatenetwork.io/address/0x77405B5aD47128c646D5D8fC5c2313c20F99B3Fc. It will still say "not found" if you put in an address that has never been used.

@ligi ligi merged commit 6747a26 into ethereum-lists:master Oct 25, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

PR merged - please consider contributing some funds to lists.eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi ligi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firelizzard18 @ligi