Add icon validation for file size and duplicates #6076
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation for icon file size and duplicate icons. * **README.md** - Add information about icon file size validation. - Add information about duplicate icon validation. * **.github/workflows/pr_checks.yml** - Add validation for icon file size in the `validate_icons` job. - Add validation for duplicate icons in the `validate_icons` job. * **maintainer_checklist.md** - Add a step to check for duplicate icons. - Add a step to check for icon file size. * **processor/src/main/kotlin/org/ethereum/lists/chains/Main.kt** - Add logic to check for duplicate icons by calculating a hash (e.g., SHA-256) of each icon file. - Add logic to validate icon file size. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ethereum-lists/chains?shareId=XXXX-XXXX-XXXX-XXXX).
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ligi
requested changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation for icon file size and duplicate icons.
README.md
.github/workflows/pr_checks.yml
validate_iconsjob.validate_iconsjob.maintainer_checklist.md
processor/src/main/kotlin/org/ethereum/lists/chains/Main.kt
For more details, open the Copilot Workspace session.