Update e2e to accept eddsa signatures #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biscuitdey
requested review from
skarred14,
ognjenkurtic,
Therecanbeonlyone1969,
Kasshern,
Ybittan and
skosito
as code owners
biscuitdey
changed the title
Therecanbeonlyone1969
previously approved these changes
Jan 24, 2024
|
@biscuitdey Is this PR supposed to make the e2e test green or is it just a step in that direction? |
@ognjenkurtic It is a step. Will get fixed in the upcoming PRs. |
skosito
reviewed
Jan 29, 2024
ognjenkurtic
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the E2E test to generate and use Eddsa keypair and signature.
Related Issue
#759
How Has This Been Tested
Code will be updated in subsequent PRs to handle the tests.
Types of changes
Checklist