Utilise Eddsa & Public Keys - Part 4 #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biscuitdey
requested review from
skarred14,
ognjenkurtic,
Therecanbeonlyone1969,
Kasshern,
Ybittan and
skosito
as code owners
|
|
This was referenced May 23, 2024
… is resource intensive
This reverts commit 4605b9c.
ognjenkurtic
approved these changes
Jun 19, 2024
9 tasks
| @@ -41,7 +41,7 @@ export class DidJwtAuthGuard implements CanActivate { | |||
| context: ExecutionContext, | |||
| ) { | |||
| // TODO: store did in bpi subject and remove constant | |||
| const didSubstrLength = 13; | |||
| const didSubstrLength = 20; | |||
There was a problem hiding this comment.
@ognjenkurtic @biscuitdey is this recorded as an issue? Cannot see it.
| ); | ||
| const signature = await wallet.signMessage(message); | ||
| const expandedSignature = ethers.utils.splitSignature(signature); | ||
| //const expandedSignature = ethers.utils.splitSignature(signature); |
There was a problem hiding this comment.
@ognjenkurtic @biscuitdey still needed as a placeholder? If not remove.
| @@ -169,7 +168,7 @@ describe('SRI use-case end-to-end test', () => { | |||
| }); | |||
|
|
|||
| it('Waits for a single VSM cycle and then verifies that the transaction has been executed and that the state has been properly stored', async () => { | |||
| await new Promise((r) => setTimeout(r, 20000)); | |||
| await new Promise((r) => setTimeout(r, 50000)); | |||
There was a problem hiding this comment.
@ognjenkurtic @biscuitdey better in constant file?
Therecanbeonlyone1969
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Eddsa signatures in circuitInputParser and computeCircuitInputs.
Related Issue
#759
Motivation and Context
Use multiple types of signatures
How Has This Been Tested
Running all existing tests
Types of changes
Checklist