Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/797 create smart contract #798

Merged
merged 8 commits into from
Jul 1, 2024
Merged

Feature/797 create smart contract #798

merged 8 commits into from
Jul 1, 2024

Conversation

biscuitdey
Copy link
Collaborator

@biscuitdey biscuitdey commented Jun 20, 2024 •
edited
Loading

Description

This PR adds a solidity contract to store the anchor hashes for each workgroupId.

Related Issue

#797

Motivation and Context

Store anchor hashes (merkle tree root + witness) on the ccsm

How Has This Been Tested

Tests would be added in upcoming PRs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

@biscuitdey biscuitdey linked an issue Jun 20, 2024 that may be closed by this pull request
SRI - CCSM : Create Smart Contract #797
Closed
3 tasks
@ognjenkurtic ognjenkurtic changed the base branch from main to develop June 25, 2024 13:54
Therecanbeonlyone1969
Therecanbeonlyone1969 reviewed Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments. once addressed good to merge ... we also need tests for the contract, please, and thank you!

examples/bri-3/src/bri/ccsm/contracts/Ccsm.sol Outdated Show resolved Hide resolved
examples/bri-3/src/bri/ccsm/contracts/Ccsm.sol Outdated Show resolved Hide resolved
examples/bri-3/src/bri/ccsm/contracts/Ccsm.sol Outdated Show resolved Hide resolved
Therecanbeonlyone1969
Therecanbeonlyone1969 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@biscuitdey biscuitdey merged commit e727269 into develop Jul 1, 2024
2 checks passed
@biscuitdey biscuitdey deleted the feature/797-create-smart-contract branch July 1, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Therecanbeonlyone1969 Therecanbeonlyone1969 Therecanbeonlyone1969 approved these changes

@skarred14 skarred14 Awaiting requested review from skarred14

@ognjenkurtic ognjenkurtic Awaiting requested review from ognjenkurtic

@Kasshern Kasshern Awaiting requested review from Kasshern

@Ybittan Ybittan Awaiting requested review from Ybittan

@skosito skosito Awaiting requested review from skosito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SRI - CCSM : Create Smart Contract
2 participants
@biscuitdey @Therecanbeonlyone1969