777 introduce dynamic circuit inputs parsing for current e2e use case #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ognjenkurtic
requested review from
skarred14,
Therecanbeonlyone1969,
Kasshern,
Ybittan,
biscuitdey and
skosito
as code owners
| } | ||
| // TODO: Example input preparation for other workstep circuits from the example use-case, to be used |
There was a problem hiding this comment.
@ognjenkurtic is that gonna be an issue you create?
| @@ -18,17 +18,12 @@ import { | |||
| } from '../../../../identity/bpiSubjects/models/publicKey'; | |||
|
|
|||
| jest.setTimeout(20000); | |||
| //NOTE: Skiping out the workstep1 as it requires compiled artifacts to run. | |||
There was a problem hiding this comment.
@ognjenkurtic will that be another issue?
There was a problem hiding this comment.
This was done by @biscuitdey . I believe these test are not needed as we can't expect the unit test suite to compile cirucits. Is it ok to remove these tests ? @biscuitdey
Therecanbeonlyone1969
approved these changes
Jul 2, 2024
ognjenkurtic
deleted the
777-introduce-dynamic-circuit-inputs-parsing-for-current-e2e-use-case
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transaction agent executeTransaction method is refactored to translate transaction payload to circuit inputs using the schema previously associated with the workstep. It utilizes the circuitInputParser service for that.
Transaction agent executeTransaction method is also refactored for better readability.
CircuitInputParser service and schema is extended to support mapping inputs from arrays of objects from the tx payload .
E2E test is extended to verify the flow works.
Related Issue
#777
Motivation and Context
SRI needs to be able to support generic use-cases when it comes to circuits and this implementation allows for that.
How Has This Been Tested
Extended unit tests
Extended e2e test
Screenshots (if appropriate)
Types of changes
Checklist