Isthmus: Tests and misc updates for L2 withdrawals root #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdamle
changed the title
vdamle
changed the title
vdamle
force-pushed
the
vd/l2-withdrawals-tests
branch
from
f790bbd
to
d4998b0
Compare
vdamle
force-pushed
the
l2-withdrawals-root
branch
from
8d2f6ac
to
823e2d9
Compare
…thdrawals storage root
and update checks for l2 withdrawal root to be gated on Isthmus instead of Holocene
vdamle
force-pushed
the
vd/l2-withdrawals-tests
branch
from
d4998b0
to
f56b4ca
Compare
added 3 commits
October 24, 2024 21:32
* To check whether Isthmus is active within NewBlock(), to appropriately handle withdrawalRoot, we need to pass in chainConfig. * Also added a Block RLP encode/decode test.
...of L2ToL1MessagePasser contract
ExecutableDataToBlockNoHash() needs to know whether Isthmus is active to determine the correct treatment of withdrawalsRoot
vdamle
commented
Oct 25, 2024
added 2 commits
October 25, 2024 14:12
regenerating binding with go1.22 results in different unmarshalling code that fails existing tests
|
@protolambda In order to update the genesis handling when reading from superchain-registry: https://github.com/ethereum-optimism/op-geth/blob/optimism/core/superchain.go#L30-L46 , I will need to make a change to SCR to:
Going to work on that PR, so there's a TBD in |
vdamle
requested review from
ajsutton and
protolambda
and removed request for
a team
tynes
reviewed
Oct 28, 2024
tynes
reviewed
Oct 28, 2024
vdamle
commented
Oct 28, 2024
tynes
reviewed
Oct 28, 2024
tynes
reviewed
Oct 28, 2024
tynes
reviewed
Oct 28, 2024
added 2 commits
October 28, 2024 10:56
they were mainly to address vscode warnings, will move it to a separate PR
vdamle
modified the milestone:
https://github.com/ethereum-optimism/optimism/milestone/10
protolambda
reviewed
Oct 31, 2024
also removed usage of a 3rd party package and custom json tags in header.
vdamle
commented
Oct 31, 2024
| // If Isthmus is active at genesis, set the WithdrawalRoot to the storage root of the L2ToL1MessagePasser contract. | ||
| if g.IsIsthmus() { | ||
| if storageRootMessagePasser == (common.Hash{}) { | ||
| // if there was no MessagePasser contract storage, set the WithdrawalsHash to the empty hash |
There was a problem hiding this comment.
The specs note that After Isthmus activation, if there was never any withdrawal contract storage, a MPT root of an empty list can be set as the withdrawalsRoot.
|
This comment is not relevant. Because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted to be merged into: #383
for TODO work items in
op-gethdocumented in: ethereum-optimism/optimism#12044