Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

challenger: Allow interrupting subcommands #10765

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Jun 6, 2024

Description

Support interrupting the execution of challenger sub-commands with ctrl-C. Just uses a very simple Context cancellation which doesn't for managing the shutdown process but that's not required for these subcommands.

Builds on #10757

Metadata

@ajsutton ajsutton requested a review from a team as a code owner June 6, 2024 23:30
@ajsutton ajsutton requested review from sebastianst and removed request for a team June 6, 2024 23:30
Copy link
Contributor

semgrep-app bot commented Jun 6, 2024

Semgrep found 2 invalid-usage-of-modified-variable findings:

Variable unsafeInNode is likely modified and later used on error. In some cases this could result in panics due to a nil dereference

Ignore this finding from invalid-usage-of-modified-variable.

@ajsutton ajsutton requested review from refcell and removed request for sebastianst June 6, 2024 23:37
Base automatically changed from aj/list-credits to develop June 6, 2024 23:44
@ajsutton ajsutton force-pushed the aj/interrupt-subcommands branch from b19aa15 to 67cb4fc Compare June 6, 2024 23:50
@ajsutton ajsutton requested a review from Inphi June 7, 2024 00:18
@ajsutton ajsutton added this pull request to the merge queue Jun 7, 2024
Merged via the queue into develop with commit 384e2dc Jun 7, 2024
64 checks passed
@ajsutton ajsutton deleted the aj/interrupt-subcommands branch June 7, 2024 00:39
rdovgan pushed a commit to rdovgan/optimism that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants