alt-da: remove unused error handling

[qzhodl]

Description

The GetInput function of s.fetcher never returns an ErrReorgRequired error, so we can remove the handling for this error type.

[tynes]

This needs a rebase for new CI jobs that were added. Also tagging @samlaf here for review

[samlaf]

Seems true to me. Tried quickly looking through previous PRs for where the ErrReorgRequired was removed from GetInput but couldn't find anything.

[qzhodl]

This needs a rebase for new CI jobs that were added. Also tagging @samlaf here for review

Sure, I’ve merged the latest changes

[samlaf]

@qzhodl Im not a member of this repo, you should request review from someone on the team. Maybe @sebastianst ?

[sebastianst]

I've confirmed that the altda.ErrReorgRequired error only bubbles up in the callstack of DA.AdvanceL1Origin so removing it for the GetInput call looks fine to me.

Is it guaranteed that this error won't be returned by GetInput in the future?

cc @qzhodl @samlaf

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (fb62380) to head (72faa22).
Report is 31 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #11828      +/-   ##
===========================================
- Coverage    64.32%   64.14%   -0.19%     
===========================================
  Files           52       52              
  Lines         4348     4348              
===========================================
- Hits          2797     2789       -8     
- Misses        1376     1385       +9     
+ Partials       175      174       -1     

Flag	Coverage Δ
cannon-go-tests	64.14% <ø> (-0.19%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

[samlaf]

@qzhodl mistake?

[qzhodl]

@qzhodl mistake?

Oh, yes, I didn’t realize the repo still has unmerged PRs...