Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isthmus: Updates for L2 withdrawals root in header #12848

Draft
wants to merge 14 commits into
base: vd/isthmus-config
Choose a base branch
from

Commits on Nov 13, 2024

  1. Add l2 withdrawals root to exec payload, ssz & gossip

    * add withdrawalsRoot to ExecutionPayload.
    * add a `BlocksV4` topic to p2p gossip and check for non-empty
      withdrawalsRoot on v4 topic.
    * add checks for whether block is type v4 and apply relevant
      marshal/unmarshal for l2 withdrawals root.
    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3a9ddc5 View commit details
    Browse the repository at this point in the history
  2. Config: Add Isthmus fork config

    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0560957 View commit details
    Browse the repository at this point in the history
  3. Update logic for l2 withdrawals root

    * attributes check
    * outputV0AtBlock api update
    * minor type updates
    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3252dff View commit details
    Browse the repository at this point in the history
  4. Test for attributes check

    and fixes for a few failures
    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    331cad9 View commit details
    Browse the repository at this point in the history
  5. op-program: use hdr withdrawalsRoot if isthmus is active

    when computing L2OutputRoot, no need to re-compute the storage root
    if Isthmus is active.
    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f1962dd View commit details
    Browse the repository at this point in the history
  6. p2p: publish blocks to v4 topic if on isthmus

    and fix lint errors
    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2616eb8 View commit details
    Browse the repository at this point in the history
  7. op-service: add a rpc response validation interface

    * `RPCResponseCheck` is an interface that currently has a function
    that validates withdrawals.
    * There's an implementation of this interface for L1 and L2
    * L1's response checker validates that the withdrawals list matches
      the root in the header.
    * L2's response checker validates that the withdrawals list is empty
      when the withdrawalsRoot is not nil
    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    36f6369 View commit details
    Browse the repository at this point in the history
  8. SSZ test, Isthmus activation at genesis action test

    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a790504 View commit details
    Browse the repository at this point in the history
  9. Action test before hard fork

    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c87f4ca View commit details
    Browse the repository at this point in the history
  10. revert op-program change

    will move to a separate PR
    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c6b60f8 View commit details
    Browse the repository at this point in the history
  11. Temp commit for action test

    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    6b3c027 View commit details
    Browse the repository at this point in the history
  12. Action test for genesis isthmus activation and activation after genesis

    * test all combinations - with/without withdrawal transaction before, at and after isthmus
    Vinod Damle committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    79609ed View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. remove action test to move to a separate branch

    raise a separate PR for it.
    Vinod Damle committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1448ad8 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Rollup-config: Add IsthmusTime

    Also fix a test in rollup, with the correct expectation for sepolia
    holocene time
    Vinod Damle committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7848fb3 View commit details
    Browse the repository at this point in the history