Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-chain-ops: draft of build-dev support for op-e2e #13768

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

protolambda
Copy link
Contributor

Description

We can support just build-dev (compiles contracts much faster) by disabling code-size checks during deployment. This won't work for live chain deployments, but does work for genesis deployment. After being initialized, the contract size is not checked by the ethereum protocol.

This PR aims to support this for op-e2e, such that allocs from a just build-dev work.

TODO: see TODO comments in the code. I am not sure what is the best way to add the option to op-deployer.

Tests

Additional context

Metadata

@protolambda protolambda requested a review from mslipper January 14, 2025 20:08
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.66%. Comparing base (f5fc73d) to head (f699b9b).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
op-chain-ops/script/script.go 0.00% 3 Missing ⚠️
op-chain-ops/script/with.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13768      +/-   ##
===========================================
- Coverage    46.97%   45.66%   -1.32%     
===========================================
  Files          957      900      -57     
  Lines        80056    75289    -4767     
  Branches       758      758              
===========================================
- Hits         37605    34379    -3226     
+ Misses       39578    38216    -1362     
+ Partials      2873     2694     -179     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 89.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-chain-ops/interopgen/deploy.go 72.32% <100.00%> (+0.20%) ⬆️
op-deployer/pkg/deployer/apply.go 50.56% <100.00%> (+0.37%) ⬆️
op-chain-ops/script/with.go 0.00% <0.00%> (ø)
op-chain-ops/script/script.go 57.83% <0.00%> (-0.23%) ⬇️

... and 68 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant