Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-challenger: Lazy create clients #13810

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ajsutton
Copy link
Contributor

Description

Only create the l2 and rollup clients when a game type actually needs them.

Make sync validator configurable per game type since we'll need a different implementation for super root games.

@ajsutton ajsutton requested review from a team as code owners January 16, 2025 15:36
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 84 lines in your changes missing coverage. Please review.

Project coverage is 42.85%. Comparing base (96f78bb) to head (468524f).

Files with missing lines Patch % Lines
op-challenger/game/fault/clients.go 0.00% 37 Missing ⚠️
op-challenger/game/fault/register.go 0.00% 34 Missing ⚠️
op-challenger/game/fault/register_task.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13810      +/-   ##
===========================================
- Coverage    47.17%   42.85%   -4.32%     
===========================================
  Files          965      800     -165     
  Lines        80468    71088    -9380     
  Branches       774        0     -774     
===========================================
- Hits         37963    30467    -7496     
+ Misses       39578    37958    -1620     
+ Partials      2927     2663     -264     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-challenger/game/fault/register_task.go 6.25% <0.00%> (-0.17%) ⬇️
op-challenger/game/fault/register.go 0.00% <0.00%> (ø)
op-challenger/game/fault/clients.go 0.00% <0.00%> (ø)

... and 171 files with indirect coverage changes

Make sync validator configurable per game type.
@ajsutton ajsutton force-pushed the aj/challenger-lazy-clients branch from 06bbec5 to 468524f Compare January 16, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant