Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add upgrade of superchain singletons #13814

Open
wants to merge 1 commit into
base: opcm-up/upgrade-asr
Choose a base branch
from

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Jan 16, 2025

TL;DR

Added support for upgrading SuperchainConfig and ProtocolVersions contracts through the OPContractsManager.

What changed?

  • Added superchainConfigImpl and protocolVersionsImpl to the OPContractsManager's Implementations struct
  • Created a new DeploySuperchainImplementations library to handle deployment of superchain implementation contracts
  • Modified the upgrade function in OPContractsManager to handle upgrading superchain contracts
  • Updated deployment scripts and tests to accommodate the new implementation contracts

How to test?

  1. Run the existing test suite which includes new tests for superchain upgrades
  2. Verify that the OPContractsManager can successfully upgrade SuperchainConfig and ProtocolVersions contracts
  3. Check that proper revert conditions are in place when upgrade requirements aren't met

Why make this change?

To enable coordinated upgrades of superchain-level contracts (SuperchainConfig and ProtocolVersions) alongside other system contracts through the OPContractsManager. This provides a more unified and secure upgrade process for the entire system.

Copy link
Contributor Author

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.68%. Comparing base (ee36e4e) to head (a943dc7).
Report is 2 commits behind head on opcm-up/upgrade-asr.

❗ There is a different number of reports uploaded between BASE (ee36e4e) and HEAD (a943dc7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ee36e4e) HEAD (a943dc7)
contracts-bedrock-tests 1 0
Additional details and impacted files
@@                   Coverage Diff                   @@
##           opcm-up/upgrade-asr   #13814      +/-   ##
=======================================================
- Coverage                45.85%   38.68%   -7.17%     
=======================================================
  Files                      901      792     -109     
  Lines                    75294    70665    -4629     
  Branches                   760        0     -760     
=======================================================
- Hits                     34525    27339    -7186     
- Misses                   38046    40945    +2899     
+ Partials                  2723     2381     -342     
Flag Coverage Δ
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 184 files with indirect coverage changes

@maurelian maurelian force-pushed the opcm-up/upgrade-asr branch from ad84635 to b633209 Compare January 16, 2025 20:42
@maurelian maurelian force-pushed the opcm-up/superchain-singletons branch from a943dc7 to 6a8bc7b Compare January 16, 2025 20:42
@maurelian maurelian marked this pull request as ready for review January 16, 2025 20:45
@maurelian maurelian requested a review from a team as a code owner January 16, 2025 20:45
@maurelian maurelian requested review from Inphi and removed request for a team January 16, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant