-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain-independent script to generate setImplementation operations #363
base: main
Are you sure you want to change the base?
Conversation
tasks/sep/fp-recovery/005-set-game-implementation/templates/NestedSignFromJson.s.sol
Outdated
Show resolved
Hide resolved
tasks/sep/fp-recovery/005-set-game-implementation/templates/NestedSignFromJson.s.sol
Outdated
Show resolved
Hide resolved
Tested this on mainnet and it works with a simulation that looks right now that the livenessGuard is automatically determined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to rebase against the latest main and re-tested, but once that is done feel free to resolve https://github.com/ethereum-optimism/superchain-ops/pull/363/files#r1828471807 and merge
…omJson.s.sol Co-authored-by: Matt Solomon <[email protected]>
…uperchain-registry. Dynamically load the safe owners. Add revert reasons to pre checks.
@mdehoog Could you help me with updating this one to handle the changes in #356 please? Getting the code to compile is easy, but now that it's rebased when I call It seems when |
ed6c36c
to
fb600bf
Compare
To reproduce the problem I'm hitting run:
|
I get the same problem without |
…p from the owner safe. Updated overrides mean the owner safe getOwners() method now returns the wrong value and can't be trusted.
Worked around this by going back to using the hard coded council and foundation safe addresses (aa9543e) but it's a shame to have to embed that into the script as it means the script itself will have to be adjusted to deal with 3-of-3 safes and other variants. Overriding the safe owners still seems kind of suspicious though, especially since it doesn't seem to completely eliminate the original owner safes. |
@ajsutton bug fix is here: base-org/contracts#105, apologies for the regression. |
Oh nice. Thanks. |
Description
Adds a template to the fp-recovery directory with tools to create operations that set the implementation for fault dispute games. Multiple implementations can be set in a single batch (e.g. setting CANNON and PERMISSIONED game type as part of a hard fork upgrade.
This would replace #354 - it generates essentially the same task but in a much more automated way and with the ability to make multiple changes in a single operation.