Skip to content

Commit

Permalink
Update EIP-6454: Remove redundant sentence in rationale
Browse files Browse the repository at this point in the history
Merged by EIP-Bot.
  • Loading branch information
ThunderDeliverer authored May 9, 2023
1 parent 9939013 commit 24eb097
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion EIPS/eip-6454.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Designing the proposal, we considered the following questions:
5. **Should we include the most straightforward method possible that only accepts a `tokenId` parameter?**\
The initial version of the proposal contained a method that only accepted a `tokenId` parameter. This method would return a boolean value indicating whether the token is transferable. However, the fact that the token can be non-transferable for different reasons was brought up throughout the discussion. This is why the method was changed to accept additional parameters, allowing for a more flexible implementation. Additionally, we kept the original method’s functionality by specifying the methodology on how to achieve the same result (by passing the `0x0000000000000000000000000000000000000000` address as the `to` and `from` parameters).
6. **What is the best user experience for frontend?**\
The best user experience for the front end is having a single method that checks whether the token is transferable. This method should handle both cases of transferability, general and conditional. This is why the second method is defined as an overload of the first method.\
The best user experience for the front end is having a single method that checks whether the token is transferable. This method should handle both cases of transferability, general and conditional.\
The front end should also be able to handle the case where the token is not transferable and the transfer is attempted. This can be done by checking the return value of the transfer function, which will be false if the token is not transferable. If the token would just be set as non-transferable, without a standardized interface to check whether the token is transferable, the only way to validate transferability would be to attempt a gas calculation and check whether the transaction would revert. This is a bad user experience and should be avoided.

## Backwards Compatibility
Expand Down

0 comments on commit 24eb097

Please sign in to comment.