Skip to content

Commit

Permalink
Add links to ERC191 and EIP712
Browse files Browse the repository at this point in the history
  • Loading branch information
@YamenMerhi
YamenMerhi committed Jul 30, 2024
1 parent 38024ab commit 278de74
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions EIPS/eip-x.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---

Check failure on line 1 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble is missing header(s): `eip` 

error[preamble-req]: preamble is missing header(s): `eip`
--> EIPS/eip-x.md
 |
 |
 = help: see https://ethereum.github.io/eipw/preamble-req/

Check failure on line 1 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble is missing header(s): `eip` 

error[preamble-req]: preamble is missing header(s): `eip`
--> EIPS/eip-x.md
 |
 |
 = help: see https://ethereum.github.io/eipw/preamble-req/
title: Add wallet_signIntendedValidatorData JSON-RPC method
title: Add wallet_signIntendedValidatorData JSON-RPC

Check failure on line 2 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `title` value is too long (max 44) 

error[preamble-len-title]: preamble header `title` value is too long (max 44)
 --> EIPS/eip-x.md:2:7
  |
2 | title: Add wallet_signIntendedValidatorData JSON-RPC
  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ too long
  |
  = help: see https://ethereum.github.io/eipw/preamble-len-title/

Check failure on line 2 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `title` value is too long (max 44) 

error[preamble-len-title]: preamble header `title` value is too long (max 44)
 --> EIPS/eip-x.md:2:7
  |
2 | title: Add wallet_signIntendedValidatorData JSON-RPC
  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ too long
  |
  = help: see https://ethereum.github.io/eipw/preamble-len-title/
description: A new RPC method to sign data with an intended validator address according to EIP-191 version 0x00.

Check failure on line 3 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

references to proposals with a `category` of `ERC` must use a prefix of `ERC` 

error[preamble-refs-description]: references to proposals with a `category` of `ERC` must use a prefix of `ERC`
 --> EIPS/eip-x.md:3:92
  |
3 | description: A new RPC method to sign data with an intended validator address according to EIP-191 version 0x00.
  |                                                                                            ^^^^^^^ referenced here
  |
  = help: see https://ethereum.github.io/eipw/preamble-refs-description/

Check failure on line 3 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

proposals mentioned in preamble header `description` must appear in `requires` 

error[preamble-requires-ref-description]: proposals mentioned in preamble header `description` must appear in `requires`
 --> EIPS/eip-x.md:3:92
  |
3 | description: A new RPC method to sign data with an intended validator address according to EIP-191 version 0x00.
  |                                                                                            ^^^^^^^ mentioned here
  |
  = help: see https://ethereum.github.io/eipw/preamble-requires-ref-description/

Check failure on line 3 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

references to proposals with a `category` of `ERC` must use a prefix of `ERC` 

error[preamble-refs-description]: references to proposals with a `category` of `ERC` must use a prefix of `ERC`
 --> EIPS/eip-x.md:3:92
  |
3 | description: A new RPC method to sign data with an intended validator address according to EIP-191 version 0x00.
  |                                                                                            ^^^^^^^ referenced here
  |
  = help: see https://ethereum.github.io/eipw/preamble-refs-description/

Check failure on line 3 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

proposals mentioned in preamble header `description` must appear in `requires` 

error[preamble-requires-ref-description]: proposals mentioned in preamble header `description` must appear in `requires`
 --> EIPS/eip-x.md:3:92
  |
3 | description: A new RPC method to sign data with an intended validator address according to EIP-191 version 0x00.
  |                                                                                            ^^^^^^^ mentioned here
  |
  = help: see https://ethereum.github.io/eipw/preamble-requires-ref-description/
author: Yamen Merhi (@YamenMerhi)
discussions-to: TBD

Check failure on line 5 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `discussions-to` is not a valid URL 

error[preamble-discussions-to]: preamble header `discussions-to` is not a valid URL
 --> EIPS/eip-x.md:5:16
  |
5 | discussions-to: TBD
  |                ^^^^ relative URL without a base
  |
  = help: see https://ethereum.github.io/eipw/preamble-discussions-to/

Check failure on line 5 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `discussions-to` should point to a thread on ethereum-magicians.org 

error[preamble-re-discussions-to]: preamble header `discussions-to` should point to a thread on ethereum-magicians.org
 --> EIPS/eip-x.md:5:16
  |
5 | discussions-to: TBD
  |                ^^^^ required pattern was not matched
  |
  = info: the pattern in question: `^https://ethereum-magicians.org/t/[^/]+/[0-9]+$`
  = help: see https://ethereum.github.io/eipw/preamble-re-discussions-to/

Check failure on line 5 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `discussions-to` is not a valid URL 

error[preamble-discussions-to]: preamble header `discussions-to` is not a valid URL
 --> EIPS/eip-x.md:5:16
  |
5 | discussions-to: TBD
  |                ^^^^ relative URL without a base
  |
  = help: see https://ethereum.github.io/eipw/preamble-discussions-to/

Check failure on line 5 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `discussions-to` should point to a thread on ethereum-magicians.org 

error[preamble-re-discussions-to]: preamble header `discussions-to` should point to a thread on ethereum-magicians.org
 --> EIPS/eip-x.md:5:16
  |
5 | discussions-to: TBD
  |                ^^^^ required pattern was not matched
  |
  = info: the pattern in question: `^https://ethereum-magicians.org/t/[^/]+/[0-9]+$`
  = help: see https://ethereum.github.io/eipw/preamble-re-discussions-to/
Expand All @@ -12,15 +12,15 @@ requires: EIP-191 - EIP-712

## Abstract

This EIP introduces a new JSON-RPC method, `wallet_signIntendedValidatorData`, which allows signing data with an intended validator address using [ERC-191](https://github.com/ethereum/ercs/blob/master/ERCS/erc-191.md) version 0x00 with this format:
This EIP introduces a new JSON-RPC method, `wallet_signIntendedValidatorData`, which allows signing data with an intended validator address using [ERC-191](./eip-191.md) version 0x00 with this format:

```bash
0x19 <0x00> <intended validator address> <data to sign>
```

## Motivation

Currently, signing messages relies heavily on ERC-191 version 0x45 (`eth_sign`) and EIP-712 (`eth_signTypedData`). While EIP-712 provides a more structured approach, it is often seen as complex. On the other hand, ERC-191 version 0x45 is widely used but poses significant phishing risks due to the lack of data parsing.
Currently, signing messages relies heavily on ERC-191 version 0x45 (`eth_sign`) and [EIP-712](./eip-712.md) (`eth_signTypedData`). While EIP-712 provides a more structured approach, it is often seen as complex. On the other hand, ERC-191 version 0x45 is widely used but poses significant phishing risks due to the lack of data parsing.

ERC-191 defines three versions: 0x45, 0x01, and 0x00. This proposal aims to fully support EIP-191 by introducing the rpc call for 0x00 version, which enables signing data with an intended validator address. This new method will:

Check failure on line 25 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

the first match of the given pattern must be a link 

error[markdown-link-first]: the first match of the given pattern must be a link
  --> EIPS/eip-x.md
   |
25 | ERC-191 defines three versions: 0x45, 0x01, and 0x00. This proposal aims to fully support EIP-191 by introducing the rpc call for 0x00 version, which enables signing data with an intended validator address. This new method will:
   |
   = info: the pattern in question: `(?i)(?:eip|erc)-[0-9]+`
   = help: see https://ethereum.github.io/eipw/markdown-link-first/

Check failure on line 25 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

references to proposals with a `category` of `ERC` must use a prefix of `ERC` 

error[markdown-refs]: references to proposals with a `category` of `ERC` must use a prefix of `ERC`
  --> EIPS/eip-x.md
   |
25 | ERC-191 defines three versions: 0x45, 0x01, and 0x00. This proposal aims to fully support EIP-191 by introducing the rpc call for 0x00 version, which enables signing data with an intended validator address. This new method will:
   |
   = help: see https://ethereum.github.io/eipw/markdown-refs/

Check failure on line 25 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

the first match of the given pattern must be a link 

error[markdown-link-first]: the first match of the given pattern must be a link
  --> EIPS/eip-x.md
   |
25 | ERC-191 defines three versions: 0x45, 0x01, and 0x00. This proposal aims to fully support EIP-191 by introducing the rpc call for 0x00 version, which enables signing data with an intended validator address. This new method will:
   |
   = info: the pattern in question: `(?i)(?:eip|erc)-[0-9]+`
   = help: see https://ethereum.github.io/eipw/markdown-link-first/

Check failure on line 25 in EIPS/eip-x.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

references to proposals with a `category` of `ERC` must use a prefix of `ERC` 

error[markdown-refs]: references to proposals with a `category` of `ERC` must use a prefix of `ERC`
  --> EIPS/eip-x.md
   |
25 | ERC-191 defines three versions: 0x45, 0x01, and 0x00. This proposal aims to fully support EIP-191 by introducing the rpc call for 0x00 version, which enables signing data with an intended validator address. This new method will:
   |
   = help: see https://ethereum.github.io/eipw/markdown-refs/

Expand Down

0 comments on commit 278de74

Please sign in to comment.