Skip to content

Commit

Permalink
Apply suggestions from review
Browse files Browse the repository at this point in the history
  • Loading branch information
pdobacz committed Sep 4, 2024
1 parent 4a5bdf3 commit 4cae577
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions EIPS/eip-7761.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
eip: 7761
title: ISCONTRACT instruction
description: Introduce ISCONTRACT instruction
description: Introduce ISCONTRACT instruction to replace the EXTCODESIZE > 0 check in EOF
author: Andrei Maiboroda (@gumb0), Piotr Dobaczewski (@pdobacz), Danno Ferrin (@shemnon)
discussions-to: https://ethereum-magicians.org/t/eip-7761-is-contract-instruction/20936
status: Draft
Expand Down Expand Up @@ -80,11 +80,11 @@ Removing code introspection is one of the tenets of EOF and `ISCONTRACT` would b

### "Endgame Account Abstraction" issues

TBD - can someone verbalize it?
TBD - can someone verbalize it? <!-- TODO -->

### Relation to [EIP-7702](./eip-7702.md) "Set EOA account code"

After [EIP-7702](./eip-7702.md) is activated, the discrimination between EOAs and contract accounts using `EXTCODESIZE` (or `ISCONTRACT`) has an edge case: Whenever an EOA sets its code to a contract account which does not respond as expected to an `onERC721Received` (`onERC1155Received`) callback, transfers to it will revert, despite the recipient being able to interact with the token. This has been deemed unlikely to be a problem, as for the intended real-world uses of `EIP-7702`, those callbacks will be implemented by designator codes.
After [EIP-7702](./eip-7702.md) is activated, the discrimination between EOAs and contract accounts using `EXTCODESIZE` (or `ISCONTRACT`) has an edge case: Whenever an EOA sets its code to a contract account which does not respond as expected to an `onERC721Received` (`onERC1155Received`) callback, transfers to it will revert, despite the recipient being able to interact with the token. This has been deemed unlikely to be a problem, as for the intended real-world uses of EIP-7702, those callbacks will be implemented by designator codes.

### Including safe guarding against proxy bricking

Expand All @@ -100,7 +100,7 @@ This problem is potentially solvable on the application layer (proxy upgrade wou

## Security Considerations

TBA
Needs discussion <!-- TODO -->

## Copyright

Expand Down

0 comments on commit 4cae577

Please sign in to comment.