Skip to content

Commit

Permalink
Update EIP-7251: fix typos
Browse files Browse the repository at this point in the history
Merged by EIP-Bot.
  • Loading branch information
macfarla committed Jul 11, 2024
1 parent 1868f75 commit e14d40e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions EIPS/eip-7251.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ The new consolidation request is an [EIP-7685](./eip-7685.md) request with type
2. `source_pubkey`: `Bytes48`
3. `target_pubkey`: `Bytes48`

The [EIP-7685](./eip-7685.md) encoding of a withdrawal request **MUST** be computed as the follows:
The [EIP-7685](./eip-7685.md) encoding of a withdrawal request **MUST** be computed as follows:

```python
encoded = CONSOLIDATION_REQUEST_TYPE ++ rlp([source_address, source_pubkey, target_pubkey])
Expand All @@ -88,14 +88,14 @@ Specifically, the functionality is defined in pseudocode as the function `add_co
```python
def add_consolidation_request(Bytes48: source_pubkey, Bytes48: target_pubkey):
"""
Add consolidaiton request adds new request to the consolidation request queue, so long as a sufficient fee is provided.
Add consolidation request adds new request to the consolidation request queue, so long as a sufficient fee is provided.
"""

# Verify sufficient fee was provided.
fee = get_fee()
require(msg.value >= fee, 'Insufficient value for fee')

# Increment consolidaiton request count.
# Increment consolidation request count.
count = sload(CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS, CONSOLIDATION_REQUEST_COUNT_STORAGE_SLOT)
sstore(CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS, CONSOLIDATION_REQUEST_COUNT_STORAGE_SLOT, count + 1)

Expand All @@ -111,7 +111,7 @@ def add_consolidation_request(Bytes48: source_pubkey, Bytes48: target_pubkey):

###### Fee calculation

The following pseudocode can compute the cost an individual consolidation request, given a certain number of excess consolidation requests.
The following pseudocode can compute the cost of an individual consolidation request, given a certain number of excess consolidation requests.

```python
def get_fee() -> int:
Expand Down Expand Up @@ -522,7 +522,7 @@ Address: 0x00b42dbF2194e931E80326D950320f7d9Dbeac02

#### Block processing

At the end of processing any execution block where `block.timestamp >= FORK_TIMESTAMP` (i.e. after processing all transactions and after performing the block body requests validations) clienst software **MUST** take the following steps:
At the end of processing any execution block where `block.timestamp >= FORK_TIMESTAMP` (i.e. after processing all transactions and after performing the block body requests validations) client software **MUST** take the following steps:

1. Call the contract as `SYSTEM_ADDRESS` and empty input data to trigger the system subroutine execute.
2. Check that consolidation requests in the [EIP-7685](./eip-7685.md) requests list matches the list returned from `dequeue_consolidation_requests()` function of the smart contract respecting the order of the returned requests. If this condition does not hold, the block **MUST** be deemed *invalid*.
Expand Down

0 comments on commit e14d40e

Please sign in to comment.