Skip to content

Commit

Permalink
Update: Update with the numbers and links
Browse files Browse the repository at this point in the history
  • Loading branch information
ulerdogan committed Jun 22, 2023
1 parent b3f1972 commit fb90cf4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions EIPS/eip-x.md → EIPS/eip-7212.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
eip: <not-assigned-yet>
eip: 7212
title: Precompiled for secp256r1 Curve Support
description: Proposal to add precompiled contract that allows signature verifications in the “secp256r1” elliptic curve.
author: Ulaş Erdoğan (@ulerdogan), Doğan Alpaslan (@doganalpaslan)
discussions-to: https://ethereum-magicians.org/
discussions-to: https://ethereum-magicians.org/t/eip-7212-precompiled-for-secp256r1-curve-support/14789
status: Draft
type: Standards Track
category: Core
Expand Down Expand Up @@ -123,8 +123,8 @@ No backward compatibility issues found as the precompiled contract will be added

Functional tests are applied for multiple cases in the [reference implementation](#Reference-Implementation) of `P256VERIFY` precompiled contract and they succeed. Benchmark tests are also applied for both `P256VERIFY` and `ECRECOVER` with some pre-calculated data and signatures in the “go-ethereum”s precompile testing structure to propose a meaningful gas cost for the “secp256r1” signature verifications by the precompiled contract implemented in the [reference implementation](#Reference-Implementation). The benchmark test results by example data in the assets can be checked:

Check failure on line 124 in EIPS/eip-7212.md

View workflow job for this annotation

GitHub Actions / Markdown Linter

Link fragments should be valid [Expected: #reference-implementation; Actual: #Reference-Implementation] [Context: "[reference implementation](#Reference-Implementation)"]

EIPS/eip-7212.md:124:56 MD051/link-fragments Link fragments should be valid [Expected: #reference-implementation; Actual: #Reference-Implementation] [Context: "[reference implementation](#Reference-Implementation)"]

Check failure on line 124 in EIPS/eip-7212.md

View workflow job for this annotation

GitHub Actions / Markdown Linter

Link fragments should be valid [Expected: #reference-implementation; Actual: #Reference-Implementation] [Context: "[reference implementation](#Reference-Implementation)"]

EIPS/eip-7212.md:124:56 MD051/link-fragments Link fragments should be valid [Expected: #reference-implementation; Actual: #Reference-Implementation] [Context: "[reference implementation](#Reference-Implementation)"]

- [P256Verify Benchmark Test Results](../assets/eip-x/p256Verify_benchmark_test)
- [Ecrecover Benchmark Test Results](../assets/eip-x/ecrecover_benchmark_test)
- [P256Verify Benchmark Test Results](../assets/eip-7212/p256Verify_benchmark_test)
- [Ecrecover Benchmark Test Results](../assets/eip-7212/ecrecover_benchmark_test)

```
# results of geth benchmark tests of
Expand Down Expand Up @@ -168,7 +168,7 @@ geomean 33.00 7.000

## Reference Implementation

Implementation of the `P256VERIFY` precompiled contract is applied to [go-ethereum](https://github.com/ethereum/go-ethereum/compare/master...ulerdogan:go-ethereum:ulerdogan-secp256r1) client to create a reference. Also, an “secp256r1” package has already been included in the [Besu Native](https://github.com/hyperledger/besu-native/tree/main/secp256r1) library which is used by [Besu](https://github.com/hyperledger/besu/blob/main/crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/SECP256R1.java) client.
Implementation of the `P256VERIFY` precompiled contract is applied to [go-ethereum](https://github.com/ethereum/go-ethereum/pull/27540) client to create a reference. Also, an “secp256r1” package has already been included in the [Besu Native](https://github.com/hyperledger/besu-native/tree/main/secp256r1) library which is used by [Besu](https://github.com/hyperledger/besu/blob/main/crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/SECP256R1.java) client.

Check failure on line 171 in EIPS/eip-7212.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image

error[markdown-rel-links]: non-relative link or image --> EIPS/eip-7212.md | 171 | Implementation of the `P256VERIFY` precompiled contract is applied to [go-ethereum](https://github.com/ethereum/go-ethereum/pull/27540) client to create a reference. Also, an “secp256r1” package has already been included in the [Besu Native](https://github.com/hyperledger/besu-native/tree/main/secp256r1) library which is used by [Besu](https://github.com/hyperledger/besu/blob/main/crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/SECP256R1.java) client. | = help: see https://ethereum.github.io/eipw/markdown-rel-links/

Check failure on line 171 in EIPS/eip-7212.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image

error[markdown-rel-links]: non-relative link or image --> EIPS/eip-7212.md | 171 | Implementation of the `P256VERIFY` precompiled contract is applied to [go-ethereum](https://github.com/ethereum/go-ethereum/pull/27540) client to create a reference. Also, an “secp256r1” package has already been included in the [Besu Native](https://github.com/hyperledger/besu-native/tree/main/secp256r1) library which is used by [Besu](https://github.com/hyperledger/besu/blob/main/crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/SECP256R1.java) client. |

Check failure on line 171 in EIPS/eip-7212.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image

error[markdown-rel-links]: non-relative link or image --> EIPS/eip-7212.md | 171 | Implementation of the `P256VERIFY` precompiled contract is applied to [go-ethereum](https://github.com/ethereum/go-ethereum/pull/27540) client to create a reference. Also, an “secp256r1” package has already been included in the [Besu Native](https://github.com/hyperledger/besu-native/tree/main/secp256r1) library which is used by [Besu](https://github.com/hyperledger/besu/blob/main/crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/SECP256R1.java) client. |

## Security Considerations

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit fb90cf4

Please sign in to comment.