Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Identity aggregated NFT #7231

Merged
merged 12 commits into from
Aug 8, 2023
Merged

Add EIP: Identity aggregated NFT #7231

merged 12 commits into from
Aug 8, 2023

Conversation

xuxinlai2002
Copy link
Contributor

…ity aggregation in NFTs (SBTs included)

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Jun 25, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 25, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Add EIP: Identity aggregated NFT, self soveriegn and composible ident… Add EIP: Identity aggregated NFT, self soveriegn and composible identity aggregation in NFTs (SBTs included) Jun 25, 2023
@eth-bot eth-bot added a-review Waiting on author to review e-consensus Waiting on editor consensus labels Jun 25, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 25, 2023
EIPS/eip-XXXX.md Outdated
@@ -0,0 +1,176 @@
---
title: Identity aggregated NFT, self soveriegn and composible identity aggregation in NFTs (SBTs included)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Identity aggregated NFT, self soveriegn and composible identity aggregation in NFTs (SBTs included)
eip: 7231
title: Identity aggregated NFT, self soveriegn and composible identity aggregation in NFTs (SBTs included)

Issuing EIP number as PR number. Please also update the filename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it, thanks a lot.

EIPS/eip-7231.md Outdated
eip: 7231
title: Identity aggregated NFT
description: The aggregation of web2 & web3 identities to NFTs, authorized by individuals, gives attributes of ownerships, relationships, experiences.
author: Chloe Gu <[email protected]>, Navid X. (@navid), Victor Yu <[email protected]>, Archer H.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to add your GitHub username (xuxinlai2002) here or else you won't be able to edit your own EIP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify @navid -> @xuxinlai2002

EIPS/eip-7231.md Outdated

## Abstract

This standard extends [ERC-721](./eip-721.md) by binding individuals' Web2 and Web3 identities to non-fungible tokens (SBTs included). By binding multiple identities, aggregated and composible identity infomation can be verified, resulting in more beneficial onchain scenarios for individuals, such as self-authentication, social overlapping, commercial value generation from user targetting, etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to include a short technical summary of the proposal in the abstract. You should answer the question of: how does this proposal attach identities to NFTs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the technical summary as follow:
By adding a custom schema in the metadata, and updating and verifying the schema hash in the contract, the binding of NFT and identity information is completed.

EIPS/eip-7231.md Outdated
## Motivation

One of the most interesting aspects of Web3 is the ability to bring an individuals own identity to different applications. Even more powerful is the fact that individuals truly own their accounts without relying on centralized gatekeepers, disclosing to different apps components necessary for authentication and approved by individuals.
Exisiting solutions such as ENS, although open, decentralized, and make it more convenient for Ethereum-based applications, lack of data standardization and athentication of itentity due to inherent anominity. Other solutions such as SBTs rely on centralized attestors, can not prevent data tampering, nor inscribe data into the ledger itself in a privacy enabling way. Previous work such as [ERC-6066](./eip-6066.md) does not bind nor verify user identity data, thus unable to meet the user identity aggregation, user Kyc verification and other application scenarios related to user data sovereignty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

athentication -> authentication
itentity -> identity

Kyc -> KYC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,has been corrected

EIPS/eip-7231.md Outdated

### Every compliant contract must implement the Interface

```typescript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```typescript
```solidity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,has been corrected

EIPS/eip-7231.md Outdated
}
```

This is the “ERCXXX Metadata JSON Schema” referenced above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where this is mentioned above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,has been corrected

EIPS/eip-7231.md Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, we recommend against including build system files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,has been corrected

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here, we recommend against adding build system files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,has been corrected

@github-actions
Copy link

The commit 1598018 (as a parent of 8eed09f) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 29, 2023
EIPS/eip-7231.md Outdated
title: Identity aggregated NFT
description: The aggregation of web2 & web3 identities to NFTs, authorized by individuals, gives attributes of ownerships, relationships, experiences.
author: Chloe Gu <[email protected]>, Navid X. (@xuxinlai2002), Victor Yu <[email protected]>, Archer H.
discussions-to: https://ethereum-magicians.org/t/eip-7231-namespaced-storage-layout/14796
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging this, the discussions-to link points to discussion on eip-7201 and not eip-7231.

@xuxinlai2002 might want to check this once.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eth-bot eth-bot changed the title Add EIP: Identity aggregated NFT, self soveriegn and composible identity aggregation in NFTs (SBTs included) Add EIP: Identity aggregated NFT Jul 2, 2023
@eth-bot eth-bot added e-review Waiting on editor to review and removed a-review Waiting on author to review labels Jul 2, 2023
EIPS/eip-7231.md Outdated
## Motivation

One of the most interesting aspects of Web3 is the ability to bring an individuals own identity to different applications. Even more powerful is the fact that individuals truly own their accounts without relying on centralized gatekeepers, disclosing to different apps components necessary for authentication and approved by individuals.
Exisiting solutions such as ENS, although open, decentralized, and make it more convenient for Ethereum-based applications, lack of data standardization and authentication of identity due to inherent anominity. Other solutions such as SBTs rely on centralized attestors, can not prevent data tampering, nor inscribe data into the ledger itself in a privacy enabling way.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Exisiting solutions such as ENS, although open, decentralized, and make it more convenient for Ethereum-based applications, lack of data standardization and authentication of identity due to inherent anominity. Other solutions such as SBTs rely on centralized attestors, can not prevent data tampering, nor inscribe data into the ledger itself in a privacy enabling way.
Exisiting solutions such as ENS, although open, decentralized, and more convenient for Ethereum-based applications, suffer from a lack of data standardization and authentication of identity due to inherent anominity. Other solutions such as SBTs rely on centralized attestors, can not prevent data tampering, and do not inscribe data into the ledger itself in a privacy enabling way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it has been revised.

EIPS/eip-7231.md Outdated Show resolved Hide resolved
EIPS/eip-7231.md Outdated Show resolved Hide resolved
@eth-bot eth-bot enabled auto-merge (squash) August 8, 2023 15:33
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 99b1bb7 into ethereum:master Aug 8, 2023
9 of 11 checks passed
@xuxinlai2002
Copy link
Contributor Author

status: Review

@navid
Copy link

navid commented Sep 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants