-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Identity aggregated NFT #7231
Conversation
…ity aggregation in NFTs (SBTs included)
✅ All reviewers have approved. |
EIPS/eip-XXXX.md
Outdated
@@ -0,0 +1,176 @@ | |||
--- | |||
title: Identity aggregated NFT, self soveriegn and composible identity aggregation in NFTs (SBTs included) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Identity aggregated NFT, self soveriegn and composible identity aggregation in NFTs (SBTs included) | |
eip: 7231 | |
title: Identity aggregated NFT, self soveriegn and composible identity aggregation in NFTs (SBTs included) |
Issuing EIP number as PR number. Please also update the filename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, got it, thanks a lot.
EIPS/eip-7231.md
Outdated
eip: 7231 | ||
title: Identity aggregated NFT | ||
description: The aggregation of web2 & web3 identities to NFTs, authorized by individuals, gives attributes of ownerships, relationships, experiences. | ||
author: Chloe Gu <[email protected]>, Navid X. (@navid), Victor Yu <[email protected]>, Archer H. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to add your GitHub username (xuxinlai2002
) here or else you won't be able to edit your own EIP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modify @navid -> @xuxinlai2002
EIPS/eip-7231.md
Outdated
|
||
## Abstract | ||
|
||
This standard extends [ERC-721](./eip-721.md) by binding individuals' Web2 and Web3 identities to non-fungible tokens (SBTs included). By binding multiple identities, aggregated and composible identity infomation can be verified, resulting in more beneficial onchain scenarios for individuals, such as self-authentication, social overlapping, commercial value generation from user targetting, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to include a short technical summary of the proposal in the abstract. You should answer the question of: how does this proposal attach identities to NFTs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the technical summary as follow:
By adding a custom schema in the metadata, and updating and verifying the schema hash in the contract, the binding of NFT and identity information is completed.
EIPS/eip-7231.md
Outdated
## Motivation | ||
|
||
One of the most interesting aspects of Web3 is the ability to bring an individuals own identity to different applications. Even more powerful is the fact that individuals truly own their accounts without relying on centralized gatekeepers, disclosing to different apps components necessary for authentication and approved by individuals. | ||
Exisiting solutions such as ENS, although open, decentralized, and make it more convenient for Ethereum-based applications, lack of data standardization and athentication of itentity due to inherent anominity. Other solutions such as SBTs rely on centralized attestors, can not prevent data tampering, nor inscribe data into the ledger itself in a privacy enabling way. Previous work such as [ERC-6066](./eip-6066.md) does not bind nor verify user identity data, thus unable to meet the user identity aggregation, user Kyc verification and other application scenarios related to user data sovereignty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
athentication -> authentication
itentity -> identity
Kyc -> KYC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,has been corrected
EIPS/eip-7231.md
Outdated
|
||
### Every compliant contract must implement the Interface | ||
|
||
```typescript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```typescript | |
```solidity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,has been corrected
EIPS/eip-7231.md
Outdated
} | ||
``` | ||
|
||
This is the “ERCXXX Metadata JSON Schema” referenced above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where this is mentioned above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,has been corrected
assets/eip-7231/hardhat.config.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, we recommend against including build system files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,has been corrected
assets/eip-7231/package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly here, we recommend against adding build system files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,has been corrected
The commit 1598018 (as a parent of 8eed09f) contains errors. |
EIPS/eip-7231.md
Outdated
title: Identity aggregated NFT | ||
description: The aggregation of web2 & web3 identities to NFTs, authorized by individuals, gives attributes of ownerships, relationships, experiences. | ||
author: Chloe Gu <[email protected]>, Navid X. (@xuxinlai2002), Victor Yu <[email protected]>, Archer H. | ||
discussions-to: https://ethereum-magicians.org/t/eip-7231-namespaced-storage-layout/14796 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging this, the discussions-to link points to discussion on eip-7201 and not eip-7231.
@xuxinlai2002 might want to check this once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ,it has been revised.
https://ethereum-magicians.org/t/erc7231-identity-aggregated-nft/15062
EIPS/eip-7231.md
Outdated
## Motivation | ||
|
||
One of the most interesting aspects of Web3 is the ability to bring an individuals own identity to different applications. Even more powerful is the fact that individuals truly own their accounts without relying on centralized gatekeepers, disclosing to different apps components necessary for authentication and approved by individuals. | ||
Exisiting solutions such as ENS, although open, decentralized, and make it more convenient for Ethereum-based applications, lack of data standardization and authentication of identity due to inherent anominity. Other solutions such as SBTs rely on centralized attestors, can not prevent data tampering, nor inscribe data into the ledger itself in a privacy enabling way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exisiting solutions such as ENS, although open, decentralized, and make it more convenient for Ethereum-based applications, lack of data standardization and authentication of identity due to inherent anominity. Other solutions such as SBTs rely on centralized attestors, can not prevent data tampering, nor inscribe data into the ledger itself in a privacy enabling way. | |
Exisiting solutions such as ENS, although open, decentralized, and more convenient for Ethereum-based applications, suffer from a lack of data standardization and authentication of identity due to inherent anominity. Other solutions such as SBTs rely on centralized attestors, can not prevent data tampering, and do not inscribe data into the ledger itself in a privacy enabling way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it has been revised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
status: Review |
please note that the wrong Navid is being tagged in these
I am Navid Navab with the email address ***@***.***
and i am not a contributor to this particular git project.
…On Tue, Sep 12, 2023 at 4:05 PM navid ***@***.***> wrote:
status: Review
—
Reply to this email directly, view it on GitHub
<#7231 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDTZO55ZHIO2HCX2VAT4TX2BT2DANCNFSM6AAAAAAZTHZTMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…ity aggregation in NFTs (SBTs included)
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: