Update EIP-7201: Move to Last Call #7519

frangio · 2023-08-23T23:55:36Z

No description provided.

eth-bot · 2023-08-23T23:56:04Z

✅ All reviewers have approved.

github-actions · 2023-08-24T18:31:40Z

The commit 9becbc1 (as a parent of 5207003) contains errors.
Please inspect the Run Summary for details.

frangio · 2023-08-25T18:28:28Z

This is ready for review @axic, @Pandapip1, @SamWilsn, @xinbenlv

frangio · 2023-08-28T19:48:44Z

Merged changes separately in #7529. Leaving this PR for the move to Last Call only.

SamWilsn

You'll need to complete the security considerations section before leaving draft.

SamWilsn · 2023-09-05T15:13:31Z

EIPS/eip-7201.md

+status: Last Call
+last-call-deadline: 2023-09-15


Generally proposals go from Draft to Review, then to Last Call. Any particular reason you're skipping Review?

The EIP has been effectively in Review for months now. I recognize we should've formalized that in the status but I only realized once we wanted to move to Last Call.

Pandapip1

I would be okay with moving from Draft to Last Call, but only if the deadline is a full month long.

Pandapip1 · 2023-09-07T16:08:38Z

EIPS/eip-7201.md

@@ -4,7 +4,8 @@ title: Namespaced Storage Layout
 description: A formula for the storage location of structs in the namespaced storage pattern.
 author: Francisco Giordano (@frangio), Hadrien Croubois (@Amxx), Ernesto García (@ernestognw), Eric Lau (@ericglau)
 discussions-to: https://ethereum-magicians.org/t/eip-7201-namespaced-storage-layout/14796
-status: Draft
+status: Last Call
+last-call-deadline: 2023-09-15


Suggested change

last-call-deadline: 2023-09-15

last-call-deadline: 2023-10-7

We've actively requested and received feedback for a while already as seen in the discussions thread.

We're going to release code using this EIP at the beginning of October so it will become de facto Final at that point, since as authors we're not going to accept normative changes after the code is released. I'll set the last call deadline to Oct 1st to match this reality.

Pandapip1

I'm okay with this irregular state transition given the longer last call deadline.

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

frangio · 2023-09-13T19:04:12Z

Is there an issue with the auto merge?

mudgen · 2023-09-15T16:23:43Z

I made a new comment about the standard here: https://ethereum-magicians.org/t/eip-7201-namespaced-storage-layout/14796/11?u=mudgen

frangio · 2023-09-19T00:05:04Z

@Pandapip1 Can you take a look at the auto merge?

xinbenlv · 2023-09-22T17:00:39Z

Agree it's a pain. For the moment can you submit a PR to move to Review first, and then we can merge the next PR to move it last call?

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

The merge-base changed after approval.

frangio · 2023-09-23T03:01:28Z

Before this can be merged @SamWilsn needs to approve the requested changes.

The security section that was requested was added in #7760.

xinbenlv · 2023-09-25T19:32:16Z

EIPS/eip-7201.md

@@ -4,7 +4,8 @@ title: Namespaced Storage Layout
 description: A formula for the storage location of structs in the namespaced storage pattern.
 author: Francisco Giordano (@frangio), Hadrien Croubois (@Amxx), Ernesto García (@ernestognw), Eric Lau (@ericglau)
 discussions-to: https://ethereum-magicians.org/t/eip-7201-namespaced-storage-layout/14796
-status: Review
+status: Last Call
+last-call-deadline: 2023-10-01


Suggested change

last-call-deadline: 2023-10-01

last-call-deadline: 2023-10-09

As mentioned earlier (#7519 (comment)) I didn't want to set the deadline beyond Oct 1st because we're doing a release that day and after that point as authors we won't accept normative changes to the EIP.

xinbenlv

Approving. Nit-pick: please don't forget to update. the Last Call Deadline.
If the merge was triggered immediately, please don't forget to create another PR to update the last call deadline date :)

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

frangio · 2023-09-25T21:09:31Z

Closed in favor of #7779.

frangio and others added 3 commits July 22, 2023 18:54

Update eip-7201.md

8313b3f

simplify

c6de071

align to 256

4205806

github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc labels Aug 23, 2023

add note about structs outside contracts

0a146be

frangio changed the title ~~Update EIP-7201: Add 256 alignment for Verkle migration and other changes~~ Update EIP-7201: Add 256 alignment and other changes, and move to Last Call Aug 23, 2023

move to last call

6643321

github-actions bot added c-status Changes a proposal's status and removed c-update Modifies an existing proposal s-draft This EIP is a Draft labels Aug 24, 2023

eth-bot changed the title ~~Update EIP-7201: Add 256 alignment and other changes, and move to Last Call~~ Update EIP-7201: Move to Last Call Aug 24, 2023

eth-bot added the e-review Waiting on editor to review label Aug 24, 2023

Amxx added 4 commits August 24, 2023 11:48

remove mention of linearity

514e230

adding a grammar definition to the Rationale section

2508f5c

texttt{keccak256}

6b00dbd

Merge branch 'master' into erc7201-align256

347e6f9

github-actions bot added the w-ci Waiting on CI to pass label Aug 24, 2023

frangio added 3 commits August 24, 2023 15:17

edit motivation

9061f1e

update specification

c90cb6b

update rationale

9becbc1

frangio added 2 commits August 24, 2023 16:30

fix latex

cffe40a

reorder frontmatter

3fd417b

github-actions bot removed the w-ci Waiting on CI to pass label Aug 24, 2023

simplify phrasing

49935ce

frangio marked this pull request as ready for review August 24, 2023 19:43

frangio requested a review from eth-bot as a code owner August 24, 2023 19:43

Merge branch 'master' into erc7201-align256

7bda2f1

poojaranjan mentioned this pull request Sep 5, 2023

EIP Editing Office Hour Meeting 24 ethcatherders/EIPIP#259

Closed

21 tasks

SamWilsn requested changes Sep 5, 2023

View reviewed changes

Pandapip1 suggested changes Sep 7, 2023

View reviewed changes

Update eip-7201.md

26a017b

Pandapip1 previously approved these changes Sep 12, 2023

View reviewed changes

eth-bot enabled auto-merge (squash) September 12, 2023 16:21

eth-bot approved these changes Sep 12, 2023

View reviewed changes

Merge branch 'master' into erc7201-align256

e4538eb

frangio requested a review from SamWilsn September 22, 2023 22:21

eth-bot previously approved these changes Sep 22, 2023

View reviewed changes

frangio mentioned this pull request Sep 22, 2023

Update EIP-7201: Move to Review #7763

Merged

Merge branch 'master' into erc7201-align256

102d87d

xinbenlv reviewed Sep 25, 2023

View reviewed changes

xinbenlv approved these changes Sep 25, 2023

View reviewed changes

eth-bot approved these changes Sep 25, 2023

View reviewed changes

frangio closed this Sep 25, 2023

auto-merge was automatically disabled September 25, 2023 21:02
Pull request was closed

frangio mentioned this pull request Sep 25, 2023

Update EIP-7201: Move to Last Call #7779

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update EIP-7201: Move to Last Call #7519

Update EIP-7201: Move to Last Call #7519

frangio commented Aug 23, 2023

eth-bot commented Aug 23, 2023 •

edited

Loading

github-actions bot commented Aug 24, 2023

frangio commented Aug 25, 2023

frangio commented Aug 28, 2023

SamWilsn left a comment

SamWilsn Sep 5, 2023

frangio Sep 6, 2023

Pandapip1 left a comment •

edited

Loading

Pandapip1 Sep 7, 2023

frangio Sep 7, 2023

Pandapip1 left a comment

eth-bot left a comment

frangio commented Sep 13, 2023

mudgen commented Sep 15, 2023

frangio commented Sep 19, 2023

xinbenlv commented Sep 22, 2023

eth-bot left a comment

frangio commented Sep 23, 2023

xinbenlv Sep 25, 2023

frangio Sep 25, 2023

xinbenlv left a comment

eth-bot left a comment

eth-bot left a comment

frangio commented Sep 25, 2023

	last-call-deadline: 2023-10-01
	last-call-deadline: 2023-10-09

Update EIP-7201: Move to Last Call #7519

Update EIP-7201: Move to Last Call #7519

Conversation

frangio commented Aug 23, 2023

eth-bot commented Aug 23, 2023 • edited Loading

github-actions bot commented Aug 24, 2023

frangio commented Aug 25, 2023

frangio commented Aug 28, 2023

SamWilsn left a comment

Choose a reason for hiding this comment

SamWilsn Sep 5, 2023

Choose a reason for hiding this comment

frangio Sep 6, 2023

Choose a reason for hiding this comment

Pandapip1 left a comment • edited Loading

Choose a reason for hiding this comment

Pandapip1 Sep 7, 2023

Choose a reason for hiding this comment

frangio Sep 7, 2023

Choose a reason for hiding this comment

Pandapip1 left a comment

Choose a reason for hiding this comment

eth-bot left a comment

Choose a reason for hiding this comment

frangio commented Sep 13, 2023

mudgen commented Sep 15, 2023

frangio commented Sep 19, 2023

xinbenlv commented Sep 22, 2023

eth-bot left a comment

Choose a reason for hiding this comment

frangio commented Sep 23, 2023

xinbenlv Sep 25, 2023

Choose a reason for hiding this comment

frangio Sep 25, 2023

Choose a reason for hiding this comment

xinbenlv left a comment

Choose a reason for hiding this comment

eth-bot left a comment

Choose a reason for hiding this comment

eth-bot left a comment

Choose a reason for hiding this comment

frangio commented Sep 25, 2023

eth-bot commented Aug 23, 2023 •

edited

Loading

Pandapip1 left a comment •

edited

Loading