Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Portal Wire Protocol a framework for discv5 #8629

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Jun 7, 2024

A draft PR for Portal Wire Protocol The foundation of other Portal Networks.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-networking labels Jun 7, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 7, 2024

File EIPS/eip-7718.md

Requires 1 more reviewers from @axic, @lightclient, @SamWilsn

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jun 7, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 7, 2024
@eth-bot eth-bot changed the title Add EIP: Portal Wire Protocol extensible generic overlay over discv5 Add EIP: Portal Wire Protocol a framework for discv5 Jun 7, 2024
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jun 7, 2024
EIPS/eip-template.md Outdated Show resolved Hide resolved
EIPS/eip-template.md Outdated Show resolved Hide resolved
EIPS/eip-template.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

The commit b14a030 (as a parent of 7a569b8) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 7, 2024
@KolbyML KolbyML marked this pull request as ready for review June 7, 2024 08:26
@KolbyML KolbyML requested a review from eth-bot as a code owner June 7, 2024 08:26
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 7, 2024
EIPS/eip-7718.md Outdated Show resolved Hide resolved
EIPS/eip-7718.md Outdated Show resolved Hide resolved
EIPS/eip-7718.md Outdated Show resolved Hide resolved
EIPS/eip-7718.md Outdated Show resolved Hide resolved
EIPS/eip-7718.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use backticks for non-code. I'd recommend using italics instead.

EIPS/eip-7718.md Outdated Show resolved Hide resolved
EIPS/eip-7718.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this file doesn't have a license, I don't think we can include it in our repository. The other alternative is to allow BitTorrent Extension Proposals as an origin for external links. See EIP-5757 for details.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we can link to ethereum/portal-network-specs I will remove this

EIPS/eip-7718.md Show resolved Hide resolved
EIPS/eip-7718.md Outdated Show resolved Hide resolved
EIPS/eip-7718.md Outdated Show resolved Hide resolved
@KolbyML
Copy link
Member Author

KolbyML commented Jul 26, 2024

@SamWilsn ready for an another review

@KolbyML KolbyML requested a review from SamWilsn July 26, 2024 18:10
EIPS/eip-7718.md Show resolved Hide resolved
EIPS/eip-7718.md Show resolved Hide resolved
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 16, 2024
@KolbyML
Copy link
Member Author

KolbyML commented Aug 16, 2024

I addressed all feedback and I am ready for a review

@github-actions github-actions bot removed the w-stale Waiting on activity label Aug 18, 2024
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no point in having an EIP where the whole specification section is defined in another document. Implementers can just, you know, read that document instead.

May I ask why you're making this proposal? We can probably figure something out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants